Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle Module Metadata - publish by default #10190

Closed
jjohannes opened this issue Aug 6, 2019 · 2 comments
Closed

Gradle Module Metadata - publish by default #10190

jjohannes opened this issue Aug 6, 2019 · 2 comments
Assignees
Labels
a:feature A new functionality in:dependency-management DO NOT USE
Milestone

Comments

@jjohannes
Copy link
Contributor

Publish Gradle Module Metadata by default, which means enabling all behavior that is now hidden behind the GRADLE_METADATA preview flag. The flag should then be made inactive.

@jjohannes jjohannes added this to the 6.0 RC1 milestone Aug 6, 2019
@jjohannes jjohannes self-assigned this Aug 12, 2019
@jjohannes
Copy link
Contributor Author

@ljacomet @melix I have merged #10274 already. Please have a look at the PR for more details and let me know if you have any comments.

I assume that this change will break some builds that work with custom repositories without proper metadata with a message like this:

> Could not find org:foo:1.0.
     Searched in the following locations:
       - https://repo.myrepo.org/repo/org/foo/1.0/foo-1.0.pom

I was wondering if we should extend the message with something like:

If the artifact you are trying to retrieve is located at the given position without metadata in 'pom' format, you need to adjust the 'metadataSources {}' (link to docs) of the 'https://repo.myrepo.org/repo/' repository declaration.

@jjohannes
Copy link
Contributor Author

jjohannes commented Aug 22, 2019

Looking into aritfact and classifier handling (traditional vs. GMM-based), I noticed a few more inconsistencies and found a small bug resulting in these changes:

  • Do not drop variant attributes in results based on maven artifacts 389c12f
  • Realized component variants need to provide all attributes b79c2a9
  • Align implementations of artifact identifier display names dbe5014
  • Fix AttributeConfigurationSelector to return the filtered result 3255f1d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature A new functionality in:dependency-management DO NOT USE
Projects
None yet
Development

No branches or pull requests

2 participants