Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance project generation generates non-functional projects for Gradle 4.x-5.5 #10454

Open
eriwen opened this issue Sep 4, 2019 · 0 comments · May be fixed by #10470

Comments

@eriwen
Copy link
Member

commented Sep 4, 2019

Expected Behavior

Generated Groovy projects should work out of the box on Gradle 4.x and above.

Current Behavior

Gradle invocations fail with:

> There is no feature named GROOVY_COMPILATION_AVOIDANCE

Context

This is due to the generated code

if(org.gradle.util.GradleVersion.current() >= org.gradle.util.GradleVersion.version("4.6")) {
enableFeaturePreview("GROOVY_COMPILATION_AVOIDANCE")
}

Groovy Compilation Avoidance wasn't introduced until 5.6. It looks like we may want to change up FileContentGenerator.groovy, but I know there are also feature previews for other features in the 4.x line, so I don't think simply changing the version string to "5.6" will work.

Steps to Reproduce

Run ./gradlew :performance:largeMonolithicGroovyProject and try to build the resulting project.

Your Environment

Build scan URL:

blindpirate added a commit that referenced this issue Sep 5, 2019
Fix enableFeaturePreview failure on template project execution
Fix #10454

Previously, lower Gradle version might not be able to execute the template project
generated because of it doesn't have some features. This commit fixes it by catching
the exception.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.