-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The wrapper script should honor http(s)_proxy variables #11065
Comments
Fixes gradle#11065. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Fixes gradle#11065. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
|
This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution. |
|
This issue has been automatically closed due to inactivity. If you can reproduce this on a recent version of Gradle or if you have a good use case for this feature, please feel free to reopen the issue with steps to reproduce, a quick explanation of your use case or a high-quality pull request. |
|
IMHO still valid. |
|
@sschuberth I saw you once committed code that honor http(s)_proxy env vars in PR #12598, but later force pushed and removed those code. Do you still think it's a good idea to honor environment variables? |
|
Yes, I still think honoring the |
|
if environment proxy variables be honored would be better, right now, seems need pass to program like |
|
Thank you for your interest in Gradle! This feature request is in the backlog of the relevant team, but this area of Gradle is currently not in focus. It might take a while before it gets implemented. |
Expected Behavior
Running
gradlewon a (Linux / Mac) system that has thehttp_proxyand / orhttps_proxyenvironment variables set should be able to download the configured Gradle distribution though the specified proxy.Current Behavior
The
gradlewscript does not pass any proxy configuration from thehttp_proxy/https_proxyenvironment variables to the JVM that runs the Java implementation for the wrapper, resulting in the download of the Gradle distribution to fail on systems that can only access the Internet via a proxy.Context
In environments behind a corporate proxy running a Gradle project's
./gradlewfails out of the box because the JVM does not know about the proxy even ifhttp_proxy/https_proxyis set. A Gradle user has to manually pass thehttp(s).proxy*JVM system properties either directly togradlewon the command line via-D, or configure them in the~/.gradle/gradle.propertiesfile.This is inconvenient extra work and not in line with other package managers / build systems like e.g. Yarn which do respect
http_proxy/https_proxy.As such it would be nice if the
gradlewscript would by default parsehttp_proxy/https_proxyand pass the information on via thehttp(s).proxy*system properties to the JVM that runs the Java implementation for the wrapper.The text was updated successfully, but these errors were encountered: