Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin DSL: fileTree(mapOf(...)) has unexpected behavior #11335

Closed
3 tasks done
bamboo opened this issue Nov 12, 2019 · 1 comment
Closed
3 tasks done

Kotlin DSL: fileTree(mapOf(...)) has unexpected behavior #11335

bamboo opened this issue Nov 12, 2019 · 1 comment

Comments

@bamboo
Copy link
Member

@bamboo bamboo commented Nov 12, 2019

Expected behaviour

The expression fileTree(mapOf("dir" to dir, "include" to listOf(glob))) should be equivalent to fileTree(dir) { include(listOf(glob)) }.

Actual behaviour

The expression fileTree(mapOf("dir" to dir, "include" to listOf(glob))) is equivalent to fileTree(baseDir = mapOf(..)) which makes no sense.

Tasks

  • Ensure the expected behaviour
  • Ensure there are no other overloads missing from the combined KotlinScript + implicit receiver API surface compared to the 5.x script templates
  • Update the upgrade guide if we decide not to support missing overloads
@eskatos
Copy link
Member

@eskatos eskatos commented Nov 15, 2019

Fixed by #11347, will ship in Gradle 6.0.1
See #11385 about the rationale for the underlying breaking change.
Closing

@eskatos eskatos closed this as completed Nov 15, 2019
@big-guy big-guy changed the title Kotlin DSL: fileTree(mapOf(...)) has unexpected behavior in Gradle 6 Kotlin DSL: fileTree(mapOf(...)) has unexpected behavior Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants