Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same infrastructure for VFS retention and continuous build #11834

Closed
lptr opened this issue Jan 8, 2020 · 11 comments · Fixed by #19569
Closed

Use same infrastructure for VFS retention and continuous build #11834

lptr opened this issue Jan 8, 2020 · 11 comments · Fixed by #19569
Assignees
Labels
in:virtual-file-system VFS, file system watching, snapshots
Milestone

Comments

@lptr
Copy link
Member

lptr commented Jan 8, 2020

We are now detecting changes on the file system in two different ways. Consolidate this.


cc: @gradle/build-cache

@lptr lptr added this to the 6.3 RC1 milestone Jan 8, 2020
@lptr
Copy link
Member Author

lptr commented Feb 17, 2020

Are we going to stop supporting continuous mode for platforms unsupported by our own native file watching, or are we going to add some proxy for the JDK's polling perhaps?

@wolfs
Copy link
Member

wolfs commented Feb 18, 2020

We could keep the JDK watcher backend around. I am also fine with dropping support for continuous build on platforms not supported by our native file watching.

@wolfs wolfs modified the milestones: 6.3 RC1, 6.5 RC1, 6.4 RC1 Feb 28, 2020
@lptr
Copy link
Member Author

lptr commented Mar 11, 2020

See thread about problematic timeouts wrt continuous mode (especially macOS): https://gradle.slack.com/archives/C0WTFHWT1/p1583943879064600

We need to update these. Searching for \b2000\b in the codebase turns them up usually.

@wolfs
Copy link
Member

wolfs commented Mar 11, 2020

Currently, most of the continuous build integration tests don't work on Java > 8 on macOS, since we don't set HIGH_FREQUENCY on the JDK watchers. See ☝️ .

@wolfs
Copy link
Member

wolfs commented Mar 11, 2020

ChangesDuringBuildContinuousIntegrationTest should be changed so it actually checks if the detected changes are picked up by the tasks which are executed.

@wolfs wolfs modified the milestones: 6.4 RC1, 6.5 RC1 Apr 6, 2020
@wolfs
Copy link
Member

wolfs commented May 3, 2020

Using the native infrastructure for continuous build will also fix #3427.

@graemerocher
Copy link

Could this be prioritized for 6.6? continuous build is a great feature but can be slow on Mac

@wolfs wolfs modified the milestones: 6.6 RC1, 6.7 RC1 Jul 2, 2020
@wolfs wolfs modified the milestones: 6.7 RC1, 7.0 RC1 Aug 17, 2020
@lptr lptr modified the milestones: 7.0 RC1, 6.8 RC1 Aug 18, 2020
@graemerocher
Copy link

Any news?

@lptr
Copy link
Member Author

lptr commented Sep 16, 2020

We are also frustrated with this issue, and will address it in the foreseeable future. It's non-trivial, though. Give us a bit more time.

@wolfs wolfs modified the milestones: 6.8 RC1, 7.0 RC1 Nov 18, 2020
@wolfs wolfs modified the milestones: 7.0 RC1, 6.9 RC1 Nov 24, 2020
@lptr lptr modified the milestones: 6.9 RC1, 7.0 RC1, 7.1 RC1 Dec 4, 2020
@avanwieringen-sensus
Copy link

Any progress on this issue? I know it is a difficult one, but just wondering :-)

@lptr
Copy link
Member Author

lptr commented Feb 11, 2021

Not for 7.0, but keep watching this space! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:virtual-file-system VFS, file system watching, snapshots
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants