Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Problems reading data from Binary store" on platforms #13251

Closed
moley opened this issue May 27, 2020 · 7 comments
Closed

"Problems reading data from Binary store" on platforms #13251

moley opened this issue May 27, 2020 · 7 comments

Comments

@moley
Copy link

@moley moley commented May 27, 2020

We are running in an exception when resolving dependencies against one directly and one transitivley defined version of the same platform.
When I am declaring a dependency to an older version of the platform directly whereas a newer version of the platform comes in as transitive dep of another platform this error occurs.

Expected Behavior

Latest platform should be resolved or at least a meaningful exception should be thrown

Current Behavior

"Problems reading data from Binary store" exception is thrown

Steps to reproduce

I have created a demo project in github, where you can reproduce it:
https://github.com/moley/platformError

Your Environment

Using a mac, but is also reproducable under windows/linux.

@melix
Copy link
Member

@melix melix commented Jun 4, 2020

Thanks for the reproducer. It seems to be even more complicated since sometimes the build passes here...

@moley
Copy link
Author

@moley moley commented Jun 4, 2020

Hi Cedric,
on our machines it was reproducable errornous. May it depends on settings like daemon or parallel build. I am on vacation the next two weeks, afterwards I can give you further infos, if needed.

@mmoayyed
Copy link

@mmoayyed mmoayyed commented Jun 4, 2020

This might also be somewhat related to the root cause, though detached from the platforms concept:
#13316 (comment)

Happy to troubleshoot, test and try fixes in snapshot form and provide feedback as much as I can.

@ljacomet
Copy link
Member

@ljacomet ljacomet commented Jun 5, 2020

We have a fix that should resolve the issue.

@moley Any chance you can confirm? Or ask someone to confirm?

Testing by updating the wrapper:

/gradlew wrapper --gradle-version=6.6-branch-ljacomet_dependency_management_graph_invalid-20200605145923+0000
ljacomet added a commit that referenced this issue Jun 8, 2020
When restarting an edge, it is possible that the new state fails to
compute the target node. In some cases, it is important to make sure the
detached edge is effectively tracked as an unattached edge.

Fixes #13251
Fixes #13316
ljacomet added a commit that referenced this issue Jun 8, 2020
When restarting an edge, it is possible that the new state fails to
compute the target node. In some cases, it is important to make sure the
detached edge is effectively tracked as an unattached edge.

Fixes #13251
Fixes #13316
@tboden
Copy link

@tboden tboden commented Jun 8, 2020

I can confirm your snapshot version fixes our original problem for which @moley reported this bug

@ljacomet
Copy link
Member

@ljacomet ljacomet commented Jun 8, 2020

Great 👍
Thanks for taking the time to confirm.

@ljacomet ljacomet closed this in 1b720bf Jun 9, 2020
@ljacomet ljacomet added this to the 6.6 RC1 milestone Jun 9, 2020
ljacomet added a commit that referenced this issue Jun 29, 2020
When restarting an edge, it is possible that the new state fails to
compute the target node. In some cases, it is important to make sure the
detached edge is effectively tracked as an unattached edge.

Fixes #13251
Fixes #13316
@ljacomet ljacomet modified the milestones: 6.6 RC1, 6.5.1 Jun 29, 2020
@moley
Copy link
Author

@moley moley commented Jul 1, 2020

Thank you for the fast fix, working fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.