Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing exclude rule merging optimizations #22358

Closed
ljacomet opened this issue Oct 11, 2022 · 1 comment
Closed

Missing exclude rule merging optimizations #22358

ljacomet opened this issue Oct 11, 2022 · 1 comment
Assignees
@ljacomet
Labels
a:bug in:dependency-resolution engine metadata
Milestone
6.9.3

Comments

@ljacomet
Copy link
Member

From larger builds, we have found missed exclude rule merging optimizations. They need to be added.
@ljacomet ljacomet added this to the 6.9.3 milestone Oct 11, 2022
@ljacomet ljacomet self-assigned this Oct 11, 2022
ljacomet added a commit that referenced this issue Oct 13, 2022
@ljacomet
Add some more optimizations for exclude simplification
942bbcd 
Changes are based on real world use cases where keeping an allOf(group(s),module(s))
instead of making it a moduleId(Set) had pretty bad downstream consequences.

Fixes #22358
ljacomet added a commit that referenced this issue Oct 14, 2022
@ljacomet
Add some more optimizations for exclude simplification
3f058e1 
Changes are based on real world use cases where keeping an allOf(group(s),module(s))
instead of making it a moduleId(Set) had pretty bad downstream consequences.

Fixes #22358
@ljacomet
Copy link
Member Author

Changes merged

@ljacomet ljacomet added in:dependency-resolution engine metadata and removed to-triage labels Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljacomet ljacomet

Labels
a:bug in:dependency-resolution engine metadata
Projects
None yet
Milestone
6.9.3
Development

No branches or pull requests
1 participant
@ljacomet