New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor nested `beforeEvaluate` requests and others #5262

Open
bamboo opened this Issue May 4, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@bamboo
Member

bamboo commented May 4, 2018

Current Behavior

Consider this code in settings.gradle:

// settings.gradle
gradle.rootProject {
    beforeEvaluate {
        println "> Outer"
        beforeEvaluate {
            println "Inner"
        }
        print "< Outer"
    }
}

This now prints:

> Outer
< Outer

And the Inner part is silently ignored.

Expected Behavior

The nested requested should be honoured asynchronously and print:

> Outer
< Outer
Inner

Context

Hooks such as beforeEvaluate and afterEvaluate are used in a lot of ways to work around ordering problems, and it's easy to end up nesting two of them. Debugging such issues can be pretty hard.

See #3411 and #5200

@JLLeitschuh

This comment has been minimized.

Contributor

JLLeitschuh commented Oct 14, 2018

@bamboo That syntax isn't supported in the Gradle Kotlin DSL. What is this in the scope of the gradle.rootProject?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment