Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail jar task on invalid 'Automatic-Module-Name' in MANIFEST #7752

Open
sormuras opened this issue Nov 16, 2018 · 4 comments
Open

Fail jar task on invalid 'Automatic-Module-Name' in MANIFEST #7752

sormuras opened this issue Nov 16, 2018 · 4 comments

Comments

@sormuras
Copy link

sormuras commented Nov 16, 2018

The default/core jar task should fail when the generated archive contains an invalid 'Automatic-Module-Name' entry.

Similar to what the JDK jar tool yields, when running jar --describe-module --file JAR-FILE.

Unable to derive module descriptor for: xyz.jar
Automatic-Module-Name: no-dash: Invalid module name: 'no-dash' is not a Java identifier

See https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names for details.

@stale
Copy link

stale bot commented Mar 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution.

@stale stale bot added the stale label Mar 23, 2021
@sormuras
Copy link
Author

@stale stale bot removed the stale label Mar 24, 2021
@stale
Copy link

stale bot commented Apr 6, 2022

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution.

@stale stale bot added the stale label Apr 6, 2022
@sormuras
Copy link
Author

sormuras commented Apr 8, 2022

Still valid. (Erm, invalid. Invalid module names are still slipping through, afaict.)

@stale stale bot removed the stale label Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants