Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a top-level class in the package may break incremental compilation #8590

Open
gavra0 opened this issue Feb 22, 2019 · 3 comments
Open

Adding a top-level class in the package may break incremental compilation #8590

gavra0 opened this issue Feb 22, 2019 · 3 comments

Comments

@gavra0
Copy link

@gavra0 gavra0 commented Feb 22, 2019

Adding a top-level class may break incremental compilation if the added type changes the type resolution.

For the following example, the incremental compilation breaks.

// foo/A.java
package foo;
import bar.*;
public class A {
  Other getOther() { return null; }
}
// bar/Other.java
package bar;
public class Other {}

In the second run, add foo/Other.java:

package foo;
public class Other {} 

After the second run foo/A.class will not be updated and it will contain incorrect reference to bar.Other instead of foo.Other.

@lptr

This comment has been minimized.

Copy link
Member

@lptr lptr commented Apr 16, 2019

@oehme could you take a look at this please?

@oehme

This comment has been minimized.

Copy link
Contributor

@oehme oehme commented Apr 16, 2019

I can, is there a specific release deadline you have in mind?

@lptr

This comment has been minimized.

Copy link
Member

@lptr lptr commented Apr 16, 2019

None that I know of. The reason I pinged you is that the issue was assigned to the build cache team, and wanted to make sure it doesn't get lost.

@oehme oehme added this to the 5.6 RC1 milestone May 21, 2019
@oehme oehme removed their assignment Jun 19, 2019
@big-guy big-guy modified the milestones: 5.6 RC1, 6.0 RC1 Jul 18, 2019
@big-guy big-guy modified the milestones: 6.0 RC1, 6.2 RC1 Sep 18, 2019
@big-guy big-guy modified the milestones: 6.2 RC1, 6.3 RC1 Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.