Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid merging old Groovy source-class mappings on full recompilation #9936

Closed
blindpirate opened this issue Jul 12, 2019 · 0 comments · Fixed by #9964

Comments

@blindpirate
Copy link
Member

commented Jul 12, 2019

@blindpirate commented on Fri Jul 12 2019

Context

Currently, if we're doing a full recompilation in some cases, we still merge the new mapping into the old mappings - this might cause problems, for example, the old mapping:

/home/myproject/src/main/groovy/A.groovy -> A

the new mapping:

A.groovy -> A

The merged mapping:

/home/myproject/src/main/groovy/A.groovy -> A
A.groovy -> A

When constructing a reverse mapping, something bad happens: which file should A be mapped to?

So we'd better fully clean up the mapping on full-recompilation.

@blindpirate blindpirate self-assigned this Jul 12, 2019
@blindpirate blindpirate added this to the 5.6 RC1 milestone Jul 12, 2019
blindpirate added a commit that referenced this issue Jul 16, 2019
This fixes #9936
Previously even on full recompilation, we merge the old Groovy source-class mappings
into the incremental mappings. This PR avoid doing this on full recompilation.
blindpirate added a commit that referenced this issue Jul 18, 2019
This fixes #9936
Previously even on full recompilation, we merge the old Groovy source-class mappings
into the incremental mappings. This PR avoid doing this on full recompilation.
blindpirate added a commit that referenced this issue Jul 20, 2019
This fixes #9936
Previously even on full recompilation, we merge the old Groovy source-class mappings
into the incremental mappings. This PR avoid doing this on full recompilation.
blindpirate added a commit that referenced this issue Jul 20, 2019
This fixes #9936
Previously even on full recompilation, we merge the old Groovy source-class mappings
into the incremental mappings. This PR avoid doing this on full recompilation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.