Let Kotlin DSL gracefully handle lambdas registered as extensions #10758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamboo
reviewed
Sep 17, 2019
...ugins/src/main/kotlin/org/gradle/kotlin/dsl/provider/plugins/DefaultProjectSchemaProvider.kt
Outdated
Show resolved
Hide resolved
eskatos
force-pushed
the
eskatos/kotlin-dsl/project-schema-lambda-extensions
branch
from
ba47fef
to
fc6ecc5
Compare
This was referenced Sep 18, 2019
eskatos
force-pushed
the
eskatos/kotlin-dsl/project-schema-lambda-extensions
branch
from
fc6ecc5
to
f9e4f29
Compare
and coverage for lost type info with typed Java and Kotlin lambdas Signed-off-by: Paul Merlin <paul@gradle.com>
eskatos
force-pushed
the
eskatos/kotlin-dsl/project-schema-lambda-extensions
branch
from
f9e4f29
to
02d6863
Compare
bamboo
approved these changes
Sep 18, 2019
eskatos
deleted the
eskatos/kotlin-dsl/project-schema-lambda-extensions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local Groovy Closure, local Kotlin lambda, local Java lambda, all makes the Kotlin DSL fails throwing an exception starting with Gradle 5.6. This is due to changes in
kotlin-reflect1.3.41 that is now more correct and refuse to answer queries it can't complete.This PR lets the
ProjectSchemaProviderskip local, anonymous and synthetic classes when finding the nearest public type visible to Kotlin when gathering the schema elements.This plugin got broken with the Kotlin DSL in Gradle 5.6 and triggered this work. It registers a local Groovy Closure as an extension: https://github.com/wpilibsuite/GradleRIO/blob/304f416e374874fd73b994999aa9fab6cbf7e4a0/src/main/groovy/edu/wpi/first/gradlerio/frc/FRCPlugin.groovy#L76-L78