Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for URI backed TextResource #2760
See #2663 for more context.
However, I have to stress something. I think that this change will not work for the main use case in the linked issue. The reason for that is the internal
Another approach would be to make sure that
If you ask me I think that it needs to be fixed in the internal
Gradle Core Team Checklist
That's great to hear. I was thinking in the same direction, but I was not sure whether it should be part of this PR
I'll see how I can make the
@oehme, I've tried to do what you proposed. However, that leads to some test failures on different location.
By looking at the documentation of the internal
I suppose that returning the downloaded file there is not correct. What would you suggest? Should I continue down this path, or should I just create a temp file from the contents of the
referenced this pull request
Aug 23, 2017
I took a look at the failing tests. They are asserting that a script using
There is some duplication between
Last but not least, we want to be lazy, i.e. don't download the file until it is really needed. For that you'll have to pass the
I think that this deserves its own issue. It will take a while if I need to do it. I think that I tried resolving it, but then other cases started failing
I'll see what I can do here. I could also extract some common class that we can delegate the work to.
Of course. Will make it lazy.