Allow Buildship to separate runtime classpath based on source set information #3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donat
changed the title
donat
changed the title
|
I'm working on the performance test failures. |
oehme
suggested changes
Oct 17, 2017
| @@ -28,6 +28,10 @@ Gradle now suppoprts version range in parent elements of POM, which was introduc | |||
| IMPORTANT: if this is a patch release, ensure that a prominent link is included in the foreword to all releases of the same minor stream. | |||
| Add--> | |||
|
|
|||
| ### Eclipse plugin separates output folders | |||
|
|
|||
| The `eclipse` plugin now defines separate output directories for each source folders. Also, each source folder and dependency defines an additional `gradle_source_sets` classpath attribute. The attribute specifies to which sourceSet the entry belonged. Future [Buildship](http://eclipse.org/buildship) versions will use this information to separate source sets when launching Java applications within Eclipse. | |||
| @@ -28,6 +28,10 @@ Gradle now suppoprts version range in parent elements of POM, which was introduc | |||
| IMPORTANT: if this is a patch release, ensure that a prominent link is included in the foreword to all releases of the same minor stream. | |||
| Add--> | |||
|
|
|||
| ### Eclipse plugin separates output folders | |||
|
|
|||
| The `eclipse` plugin now defines separate output directories for each source folders. Also, each source folder and dependency defines an additional `gradle_source_sets` classpath attribute. The attribute specifies to which sourceSet the entry belonged. Future [Buildship](http://eclipse.org/buildship) versions will use this information to separate source sets when launching Java applications within Eclipse. | |||
There was a problem hiding this comment.
❌ This section is outdated. It does not reflect the actual implementation. How about not going into this detail at all and just explaining what it does? I had a draft of that on my branch.
There was a problem hiding this comment.
I added the text from your branch.
donat
force-pushed
the
donat/ide/eclipse-cp-separation
branch
from
92e1eaa
to
da9213f
Compare
oehme
approved these changes
Oct 18, 2017
This reverts commit 0f7ac32.
Eclipse source folders each have a scope assigned to them. This is currently the name of the SourceSet, but might evolve later to be the name of the component instead. The exact value is an implementation detail. However, we also need to track all the scopes that *use* that source folder, so its output can be included when running applications and tests in Eclipse. The output folder is not explicitly modeled in the .classpath file, but instead implicitly belongs to the source folder.
When calculating the linked resources, there's no need to set all attributes for the source directories because only the name and the location is used by LinkedResourcesCreator.
The source folder calculation is an expensive operation, yet it was called multiple times inside SourceFolderCreator.createSourceFolders() method.
donat
force-pushed
the
donat/ide/eclipse-cp-separation
branch
from
94cfc53
to
c052c18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains all changes required for eclipse/buildship#354: