New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle signing plugin documentation update #4023

Merged
merged 1 commit into from Jan 15, 2018

Conversation

Projects
None yet
2 participants
@dryganets
Contributor

dryganets commented Jan 12, 2018

Context

It is hard to figure out how to use the signing plugin correctly now.

  1. It turns out that we need to provide last 8 hex digits of gpg -K output.
  2. the secring.pgp file is deprecated since pgp 2.1. It is better to have it documented.

Contributor Checklist

  • Review Contribution Guidelines
  • Make sure that all commmits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
  • Provide unit tests (under <subproject>/src/test) to verify logic
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation
  • Recognize contributor in release notes
gradle signing plugin documentation update
Signed-off-by: Sergei Dryganets <sergeyd@microsoft.com>

@eriwen eriwen self-assigned this Jan 15, 2018

@eriwen eriwen self-requested a review Jan 15, 2018

@eriwen

This comment has been minimized.

Member

eriwen commented Jan 15, 2018

Thank you for your contribution @dryganets! This looks like helpful information. I'm going to merge it and add some backticks around commands to highlight them a little.

@eriwen eriwen added this to the 4.6 RC1 milestone Jan 15, 2018

@eriwen eriwen merged commit 8b33aec into gradle:master Jan 15, 2018

1 check passed

DCO All commits have a DCO sign-off from the author
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment