New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xref id to java-gradle-plugin section of user guide #4179

Merged
merged 1 commit into from Jan 29, 2018

Conversation

Projects
None yet
2 participants
@k-mack
Contributor

k-mack commented Jan 28, 2018

Context

The xref ID for the section on the java-gradle-plugin was previously changed from javaGradle_plugin to java_gradle_plugin. However, not all places using the xref ID were updated to use the new ID.

This patch replaces the old xref ID with the new one.

No previous issue for this exists (at least, not that I could find).

Contributor Checklist

  • Review Contribution Guidelines
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
  • Provide unit tests (under <subproject>/src/test) to verify logic
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation
  • Recognize contributor in release notes
Fix xref to java-gradle-plugin section
The xref ID for the section on the java-gradle-plugin was previously
changed from `javaGradle_plugin` to `java_gradle_plugin`.  However, not
all places using the xref ID were updated to use the new ID.

This patch replaces the old xref ID with the new one.

Signed-off-by: Kevin Macksamie <kevin.macksamie@gmail.com>

@bmuschko bmuschko self-assigned this Jan 29, 2018

@bmuschko bmuschko added this to the 4.6 RC1 milestone Jan 29, 2018

@bmuschko

This comment has been minimized.

Contributor

bmuschko commented Jan 29, 2018

Nice, good catch. Thanks for providing the pull request!

@bmuschko bmuschko merged commit ad094aa into gradle:master Jan 29, 2018

2 checks passed

DCO All commits have a DCO sign-off from the author
WIP ready for review
Details

@bmuschko bmuschko changed the title from Fix xref id to java-gradle-plugin section to Fix xref id to java-gradle-plugin section of user guide Jan 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment