New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade codeNarc to version 1.1 #4917

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
3 participants
@debanne
Contributor

debanne commented Apr 3, 2018

Signed-off-by: Emmanuel Debanne e.debanne@criteo.com

Context

Changelog: https://github.com/CodeNarc/CodeNarc/blob/master/CHANGELOG.md#version-11-jan-2018

Contributor Checklist

  • Review Contribution Guidelines
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
  • Provide unit tests (under <subproject>/src/test) to verify logic
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation
  • Recognize contributor in release notes

@blindpirate blindpirate merged commit b3363ad into gradle:master Apr 18, 2018

7 checks passed

Branch Build Accept (Trigger) (Check) TeamCity build finished
Details
DCO All commits have a DCO sign-off from the author
Performance Test Coordinator - Linux (Branch Build Accept) TeamCity build finished
Details
Quick Feedback (Trigger) (Check) TeamCity build finished
Details
Quick Feedback - Linux Only (Trigger) (Check) TeamCity build finished
Details
Sanity Check (Quick Feedback - Linux Only) TeamCity build finished
Details
WIP ready for review
Details
@blindpirate

This comment has been minimized.

Member

blindpirate commented Apr 18, 2018

Thanks @debanne !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment