Add ReplacedBy attribute to identify properties that are replaced by … #8581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…other properties This is informational only for now. @ReplacedBy is treated like @internal.
adammurdoch
requested changes
Feb 21, 2019
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.gradle.api.tasks; |
There was a problem hiding this comment.
This shouldn't be task specific, because we want to do similar kind of things (documentation, validation, migration magic, ignore as state) for extensions and other model types.
| @@ -89,6 +90,10 @@ PropertyAnnotationHandler createInternalAnnotationHandler() { | |||
| return new NoOpPropertyAnnotationHandler(Internal.class); | |||
| } | |||
|
|
|||
| PropertyAnnotationHandler createReplacedByAnnotationHandler() { | |||
There was a problem hiding this comment.
Can you also update 'ValidateTaskPropertiesIntegrationTest` to verify we don't complain about a property with this annotation.
Also, we should probably complain or fail when another input or output annotation is attached to a @ReplacedBy property, as the annotations should move to the new property.
Make sure we get an error if you combine two annotations with ReplacedBy
big-guy
force-pushed
the
sg/provider/replacedby
branch
from
38d8b04
to
b02eccf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…other properties
This is informational only for now. @ReplacedBy is treated like @internal.
Context
Contributor Checklist
<subproject>/src/integTest) to verify changes from a user perspective<subproject>/src/test) to verify logic./gradlew <changed-subproject>:checkGradle Core Team Checklist