Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS for GoogleAPIs repository #8927

Merged
merged 1 commit into from Apr 3, 2019

Conversation

lacasseio
Copy link
Contributor

Context

See https://github.com/gradle/gradle-private/issues/2027

Gradle Core Team Checklist

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation
  • Recognize contributor in release notes

@lacasseio lacasseio added from:member a:chore in:building-gradle gradle/gradle build @core Issue owned by GBT Core labels Apr 2, 2019
@lacasseio lacasseio added this to the 5.4 RC1 milestone Apr 2, 2019
@lacasseio lacasseio self-assigned this Apr 2, 2019
@lacasseio lacasseio requested a review from donat April 2, 2019 16:51
@lacasseio lacasseio changed the base branch from master to release April 2, 2019 16:51
Copy link
Member

@donat donat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lacasseio lacasseio merged commit 0c3f23a into release Apr 3, 2019
@lacasseio lacasseio deleted the lacasseio/use-https-for-google-api-js branch April 3, 2019 09:04
@andevani
Copy link

Hi Team,

We are using plugin : 'Java' in our gradle project.

As this vulnerability is for 'Javascript' and 'Coffeescript' plugin, is it necessary for us to upgrade gradle version?

Kindly suggest.

@lacasseio
Copy link
Contributor Author

If you are using the API in your build script to add the repository then there is a potential. A deeper analysis would be require for finding out if you are indeed vulnerable when using the API. All this change does is default to HTTPS when adding the repository. If you don't use the API, there is nothing to worry about on that specific issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:chore @core Issue owned by GBT Core in:building-gradle gradle/gradle build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants