New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `ProjectExtensionsTaskRegistrationAction` configuration overhead #320

Closed
bamboo opened this Issue Mar 31, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@bamboo
Member

bamboo commented Mar 31, 2017

Execution cost should only be paid by Kotlin based projects.

An alternative implementation would be to introduce a service that reacts to Kotlin build script evaluation events and registers the tasks as needed.

@bamboo

This comment has been minimized.

Show comment
Hide comment
@bamboo

bamboo Apr 12, 2017

Member

A better strategy would be to apply a plugin to the root project from KotlinScriptPlugin. That plugin would register the gskGenerateAccessors task.

Member

bamboo commented Apr 12, 2017

A better strategy would be to apply a plugin to the root project from KotlinScriptPlugin. That plugin would register the gskGenerateAccessors task.

@eskatos eskatos self-assigned this Apr 13, 2017

eskatos added a commit that referenced this issue Apr 13, 2017

Remove ProjectExtensionsTaskRegistrationAction, apply a plugin instead
That way, no need to check for .kts files presence.
Builds not using gsk won’t suffer the performance penalty anymore.
Builds using gsk will benefit a small performance gain.

See #320

eskatos added a commit that referenced this issue Apr 18, 2017

Remove ProjectExtensionsTaskRegistrationAction, apply a plugin instead
That way, no need to check for .kts files presence.
Builds not using gsk won’t suffer the performance penalty anymore.
Builds using gsk will benefit a small performance gain.

See #320

eskatos added a commit that referenced this issue Apr 18, 2017

Remove ProjectExtensionsTaskRegistrationAction, apply a plugin instead
That way, no need to check for .kts files presence.
Builds not using gsk won’t suffer the performance penalty anymore.
Builds using gsk will benefit a small performance gain.

See #320

eskatos added a commit that referenced this issue Apr 19, 2017

Remove ProjectExtensionsTaskRegistrationAction, apply a plugin instead
That way, no need to check for .kts files presence.
Builds not using gsk won’t suffer the performance penalty anymore.
Builds using gsk will benefit a small performance gain.

See #320
@eskatos

This comment has been minimized.

Show comment
Hide comment
@eskatos

eskatos Apr 25, 2017

Member

This has been merged

Member

eskatos commented Apr 25, 2017

This has been merged

@eskatos eskatos closed this Apr 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment