New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'maven-publish' plugin with the 'java-library' plugin does not include dependencies that are added after publication creation #327

Closed
mkobit opened this Issue Apr 8, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@mkobit
Contributor

mkobit commented Apr 8, 2017

Expected Behavior

Dependencies added after a MavenPublication is created should also be in the POM descriptor.

Current Behavior

The API dependencies are different in .kts build scripts compared to Groovy build scripts.

Context

Trying to configure a Maven publication in a GSK script.

Steps to Reproduce (for bugs)

  1. git clone https://github.com/mkobit/gradle-java-library-maven-publishing-problem.git
  2. ./gradlew generatePom
  3. Open up invalid-library-example/build/publications/mavenJavaLibrary/pom-default.xml and view the generated publication POM
  4. ./gradlew clean generatePom -PuseKts to generate using what I believe is the same script configured for GSK
  5. Open up invalid-library-example/build/publications/mavenJavaLibrary/pom-default.xml and see the different in the compile scope dependencies in the generated publication POM have both guice and apache-commons missing

Your Environment

@mkobit

This comment has been minimized.

Show comment
Hide comment
@mkobit

mkobit Apr 8, 2017

Contributor

I updated the repository to also demonstrate the problem with implementation as well.

Contributor

mkobit commented Apr 8, 2017

I updated the repository to also demonstrate the problem with implementation as well.

@mkobit mkobit changed the title from 'maven-publish' plugin with the 'java-library' plugin does not include "api" dependencies when configured using `project(":subproject-path") {}` in parent project or when configuring the subproject itself to 'maven-publish' plugin with the 'java-library' plugin does not include dependencies that are added after publication creation Apr 10, 2017

@mkobit

This comment has been minimized.

Show comment
Hide comment
@mkobit

mkobit Apr 10, 2017

Contributor

I've updated the description and pushed up smaller example to at least demonstrate more of what I am running into.

Contributor

mkobit commented Apr 10, 2017

I've updated the description and pushed up smaller example to at least demonstrate more of what I am running into.

@bamboo bamboo added this to the 0.9.0 milestone Apr 10, 2017

@bamboo

This comment has been minimized.

Show comment
Hide comment
@bamboo

bamboo Apr 10, 2017

Member

Thanks for the report!

Member

bamboo commented Apr 10, 2017

Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment