Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1150 - Add js test sample #1386

Open
wants to merge 1 commit into
base: master
from

Conversation

@Patouche
Copy link

commented Jun 15, 2019

Context

Provide test for samples js "hello-js" (see #1150 for further details)

Made during https://hack-commit-pu.sh/ event.

Thanks a lot to @aalmiray for his participation.

@eskatos
Copy link
Member

left a comment

Thank you for the PR @Patouche.
It passed the Travis checks on Java 11. The Java 8 setup is currently broken, please ignore it.

I left a few comments.
Could you also please add a test for the sample in HelloJsSampleTest? I think running the test task would be enough.

Before we can accept your contribution, you need to sign-off your commits, see the failed DCO check on Github https://github.com/gradle/kotlin-dsl/pull/1386/checks?check_run_id=149137955 for how to proceed.

}
}

node {

This comment has been minimized.

Copy link
@eskatos

eskatos Jun 17, 2019

Member

iirc, this is the node project extension, not a task. I would move its configuration out of the tasks {} block to make this clear. Or, if setting the node version isn't required for this sample it could simply be removed, your call.

version = "10.16.0"
}

karma {

This comment has been minimized.

Copy link
@eskatos

eskatos Jun 17, 2019

Member

this is also a project extension, please move its configuration out of the tasks {} block

outputs.dir(outputDir)
doLast {
val fromJars = configurations.testCompileClasspath.get()
.filter { it.name.matches(Regex(".*\\.jar")) }

This comment has been minimized.

Copy link
@eskatos

eskatos Jun 17, 2019

Member
Suggested change
.filter { it.name.matches(Regex(".*\\.jar")) }
.filter { it.extension == "jar") }
#1150 - Add js test sample
Signed-off-by: Patrick Allain <allain.pat@gmail.com>

# Please enter the commit message for your changes. Lines starting
# with '#' will be kept; you may remove them yourself if you want to.
# An empty message aborts the commit.
#
# Date:      Sat Jun 15 17:37:07 2019 +0200
#
# On branch master
# Your branch is up to date with 'origin/master'.
#
# Changes to be committed:
#	modified:   samples/hello-js/build.gradle.kts
#	new file:   samples/hello-js/src/main/kotlin/samples/Greeter.kt
#	new file:   samples/hello-js/src/test/kotlin/samples/GreeterTest.kt
#

@Patouche Patouche force-pushed the Patouche:master branch from 3b58759 to b9c63ca Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.