Cardinality support for Druid #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranit22
requested changes
Feb 22, 2018
dist/partials/query.editor.html
Outdated
| @@ -351,6 +362,11 @@ | |||
| <input type="text" ng-switch-when="count" class="input-small gf-form-input" spellcheck='false' ng-model="ctrl.target.currentAggregator.name" placeholder="output name" ng-blur="ctrl.targetBlur()"> | |||
| <gf-form-switch ng-switch-when="count" class="gf-form" label="Hidden" label-class="query-keyword" checked="ctrl.target.currentAggregator.hidden"></gf-form-switch> | |||
| </div> | |||
| <div class="gf-form" ng-show="ctrl.addAggregatorMode" ng-switch on="ctrl.target.currentAggregator.type"> | |||
| <input type="text" ng-switch-when="cardinality" class="input-small gf-form-input width-10" spellcheck='false' ng-model="ctrl.target.currentAggregator.name" placeholder="output name" ng-blur="ctrl.targetBlur()"> | |||
| <input type="text" ng-switch-when="cardinality" class="input-small gf-form-input width-10" spellcheck='false' ng-model="ctrl.target.currentAggregator.fieldNames" ng-blur="ctrl.targetBlur()" placeholder="metric name" bs-typeahead="ctrl.getMetrics" data-min-length=0> | |||
There was a problem hiding this comment.
@gavinmcnair I have tested your changes and the code works well for cardinality. Can we also include dimensions along with metrics top appear in the autocomplete for this field? We need to add another method similar to getMetrics in order to get metrics and dimensions as a single set. This will make this feature (of cardinality support) complete.
There was a problem hiding this comment.
Not being a front end JS developer means this will take me a while to get done. I'll try and give it a go over the next few days.
Autocomplete cardinality metrics and dimensions
|
Hi @pranit22 those changes have been made. Can you please test and merge? |
|
@pranit22 brought the branch up to date with master and updated jsdom to be compatible with v8+ node versions |
pranit22
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not a JS developer so this might need rejigging. It has however transformed our dashboards and seems to work flawlessly.