Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grafanaService.go #735

Merged
merged 5 commits into from May 6, 2022
Merged

Conversation

gitgaoxiang
Copy link
Contributor

@gitgaoxiang gitgaoxiang commented Apr 27, 2022

fix: the nodeport setting does not take effect #730

Description

changes: Added nodeport handling for port 3000
motivation and context: use customize nodeport replace ingress

Relevant issues/tickets

the nodeport setting does not take effect #730

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

  1. when i apply this
  service:
    name: "grafana-service"
    labels:
      app: "grafana"
      type: "grafana-service"
    ports:
      - { nodePort: 3000, port: 3000, protocol: TCP, name: web }
    type: NodePort

the result is
image
2. when apply

  service:
    name: "grafana-service"
    labels:
      app: "grafana"
      type: "grafana-service"
    ports:
      - { nodePort: 3000, port: 3000, protocol: TCP, name: web }
      - { nodePort: 3001, port: 3001, protocol: TCP, name: web1 }
    type: NodePort

the result is
image
3. when apply

  service:
    name: "grafana-service"
    labels:
      app: "grafana"
      type: "grafana-service"
    ports:
      - { port: 3000, protocol: TCP, name: web }
      - { port: 3001, protocol: TCP, name: web1 }
    type: NodePort

the result is
image

@HubertStefanski
Copy link
Member

HubertStefanski commented May 3, 2022

@gitgaoxiang Looks good to me! can you make sure test/fmt pass?

Copy link
Member

@NissesSenap NissesSenap left a comment

LGTM

@NissesSenap NissesSenap merged commit bc9d62a into grafana-operator:master May 6, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants