Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable RequeueDelay #741

Merged

Conversation

addreas
Copy link
Contributor

@addreas addreas commented May 5, 2022

Description

Allows the current default of refreshing dashboards every 10 seconds to be configured. This might be useful in the situation where something isn't configured correctly, or there are a huge amount of dashboards such that the operator is constantly busy updating dashboards which might make it hard to understand what is happening.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

Tested on a home cluster and seems to work as intended.

@addreas addreas force-pushed the configurable-requeue-delay branch from cbd992f to baff31b Compare May 5, 2022
@addreas addreas marked this pull request as ready for review May 5, 2022
@NissesSenap
Copy link
Member

NissesSenap commented May 5, 2022

@addreas I took a quick check and i think it's a great idea and should have probably been the case from the get go but you learn every day.

Could you write something about it in the docs?
I guess https://github.com/grafana-operator/grafana-operator/blob/master/documentation/deploy_grafana.md#operator-flags is the place to put it.

@NissesSenap
Copy link
Member

NissesSenap commented May 6, 2022

@addreas I took the liberty of writing a small mention about this in the docs since I really wanted this feature in the new release.
Thanks for your great contributions!

@NissesSenap NissesSenap merged commit 707eaff into grafana-operator:master May 6, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants