Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nil check for service & service ports before iterating #748

Merged

Conversation

jacobsee
Copy link
Contributor

@jacobsee jacobsee commented May 7, 2022

Description

Simple fix: add a nil check for service & service ports before iterating in GetServicePorts

Relevant issues/tickets

#746

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

@NissesSenap NissesSenap merged commit a1245e3 into grafana-operator:master May 8, 2022
8 checks passed
@NissesSenap
Copy link
Member

NissesSenap commented May 8, 2022

Thanks for the quick action @jacobsee
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants