Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx GrafanaNotificationChannel cr not have UID will cause the program to crash #751

Merged
merged 2 commits into from May 13, 2022

Conversation

gitgaoxiang
Copy link
Contributor

@gitgaoxiang gitgaoxiang commented May 9, 2022

Fix: [Bug] GrafanaNotificationChannel cr not have UID will cause the program to crash #747

Description

Relevant issues/tickets

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

Fix: [Bug] GrafanaNotificationChannel cr not have UID will cause the program to crash grafana-operator#747
@gitgaoxiang gitgaoxiang changed the title Update grafananotificationchannel_controller.go FIx GrafanaNotificationChannel cr not have UID will cause the program to crash May 9, 2022
Copy link
Member

@HubertStefanski HubertStefanski left a comment

LGTM, thanks for contributing @gitgaoxiang !

@NissesSenap NissesSenap merged commit 2cde511 into grafana-operator:master May 13, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants