Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Bump CI versions to latest releases #771

Merged
merged 10 commits into from Jun 15, 2022

Conversation

NissesSenap
Copy link
Member

@NissesSenap NissesSenap commented Jun 6, 2022

Description

  • checkout to v3
  • go to v3
  • hadolint to v2.1.0
  • /golangci-lint v2.5.2

Relevant issues/tickets

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

NissesSenap added 4 commits Jun 6, 2022
* checkout to v3
* go to v3
* hadolint to v2.1.0
* /golangci-lint v2.5.2
For some reason it's not always possible to download
latest version of checkout
@NissesSenap
Copy link
Member Author

NissesSenap commented Jun 6, 2022

I'm hitting some cache that makes it use the old v3 definition for checkout even if I have updated that.
Will try to trigger this PR again.

@NissesSenap
Copy link
Member Author

NissesSenap commented Jun 6, 2022

Just to verify I used act
Which runs github actions locally on your computer.

act pull_request -W .github/workflows/pr-validation.yaml

And the versions is able to download without any issues. I get some other errors but that is another thing....

@HubertStefanski
Copy link
Member

HubertStefanski commented Jun 7, 2022

LGTM, but we're seeing a version resolution failure on hadolint and api-docs,

seems like the latest available version for hadolint is v2.0.0 not v2.1.0 🤔 https://github.com/marketplace/actions/hadolint-action

@NissesSenap
Copy link
Member Author

NissesSenap commented Jun 15, 2022

It was me that were using some old github-action. If i wrote the correct organiaztion and repo it all of the sudden started to work much better :P
It's only v2.0.0 that was documented, but if you look at the releases you will see that 2.1.0 is avaliable.

@HubertStefanski HubertStefanski merged commit ace2072 into grafana-operator:master Jun 15, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants