Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noProxy setting n spec.deployment.httpProxy of Grafana resource #778

Merged
merged 6 commits into from Jun 21, 2022

Conversation

mosuke5
Copy link
Contributor

@mosuke5 mosuke5 commented Jun 15, 2022

Description

Add noProxy setting in spec.deployment.httpProxy of Grafana resource.

Relevant issues/tickets

#736

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

$ cat <<EOF | kubectl apply -f -
apiVersion: integreatly.org/v1alpha1
kind: Grafana
metadata:
  name: grafana-sample-with-proxy
spec:
  ingress:
    enabled: True
  config:
    security:
      admin_user: admin
      admin_password: admin
  deployment:
    httpProxy:
      enabled: true
      url: http://192.168.1.10:8080
      secureUrl: http://192.168.1.10:8080
      noProxy: ".cluster.local,.svc,.example.com,localhost"
EOF

grafana.integreatly.org/grafana-sample-with-proxy created

$ kubectl get pod -o yaml | grep -A1 NO_PROXY
      - name: NO_PROXY
        value: .cluster.local,.svc,.example.com,localhost

pb82
pb82 approved these changes Jun 21, 2022
Copy link
Contributor

@pb82 pb82 left a comment

Verified locally, thanks @mosuke5

@pb82 pb82 merged commit f54e4e7 into grafana-operator:master Jun 21, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants