Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scraping service: Explore allowing failed Agents in hash ring #130

Closed
rfratto opened this issue Jun 29, 2020 · 2 comments · Fixed by #373
Closed

Scraping service: Explore allowing failed Agents in hash ring #130

rfratto opened this issue Jun 29, 2020 · 2 comments · Fixed by #373
Labels
enhancement New feature or request frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. keepalive Never close from staleness

Comments

@rfratto
Copy link
Member

rfratto commented Jun 29, 2020

If an Agent goes down and a config hashes to it, that config will not be loaded until the node is forgotten from the ring. Can we remove the dependency on the quorum checking for the Agent? It's not clear if we benefit from the same guarantees that Cortex needs when looking up something in the ring.

@rfratto rfratto added enhancement New feature or request question labels Jun 29, 2020
@stale
Copy link

stale bot commented Oct 3, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue/PR mark as stale due lack of activity label Oct 3, 2020
@rfratto rfratto added the keepalive Never close from staleness label Oct 5, 2020
@stale stale bot removed the stale Issue/PR mark as stale due lack of activity label Oct 5, 2020
@rfratto
Copy link
Member Author

rfratto commented Jan 26, 2021

It looks like Cortex now supports custom replication strategies for reading the ring. This should be fairly simple to implement.

@rfratto rfratto added size/m and removed question labels Jan 26, 2021
@rfratto rfratto mentioned this issue Feb 1, 2021
3 tasks
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. keepalive Never close from staleness
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant