From 1f6e22e321d03e57ac72a4542df2a1973692ee6a Mon Sep 17 00:00:00 2001 From: Gabriel Mabille Date: Tue, 29 Apr 2025 17:50:33 +0200 Subject: [PATCH 1/5] Chore: make sure github action follow best practises --- .github/workflows/go.yml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index de5d299..6782a36 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -3,6 +3,8 @@ name: Go +permissions: {} + on: push: branches: ["main"] @@ -14,6 +16,8 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 + with: + persist-credentials: false - name: Set up Go uses: actions/setup-go@v5 with: @@ -28,11 +32,13 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 + with: + persist-credentials: false - uses: actions/setup-go@v5 with: go-version-file: ./go.mod - name: golangci-lint - uses: golangci/golangci-lint-action@v6 + uses: golangci/golangci-lint-action@1481404843c368bc19ca9406f87d6e0fc97bdcfd #v7.0.0 with: version: v1.62.0 skip-cache: true @@ -43,8 +49,10 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: Install buf - uses: bufbuild/buf-setup-action@v1 + uses: bufbuild/buf-setup-action@a47c93e0b1648d5651a065437926377d060baa99 #v1 - name: Generate protobuf run: buf generate - name: Check for git diff From da4318aa0e014ca7b078d1045e221d7f8dd7f16f Mon Sep 17 00:00:00 2001 From: Gabriel Mabille Date: Wed, 30 Apr 2025 15:35:38 +0200 Subject: [PATCH 2/5] empty From 197fa0eb77d317ba8ad9a435ed9aac2b97c78380 Mon Sep 17 00:00:00 2001 From: Gabriel Mabille Date: Wed, 30 Apr 2025 15:40:56 +0200 Subject: [PATCH 3/5] Fix error --- .github/workflows/go.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 6782a36..d840329 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -40,7 +40,7 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@1481404843c368bc19ca9406f87d6e0fc97bdcfd #v7.0.0 with: - version: v1.62.0 + version: v2.1.5 skip-cache: true install-mode: binary codegen: From 583fafde90a2e377a86d708ec5a690fb4d2d5ae7 Mon Sep 17 00:00:00 2001 From: Gabriel Mabille Date: Wed, 30 Apr 2025 15:43:34 +0200 Subject: [PATCH 4/5] Don't upgrate yet as linting fails --- .github/workflows/go.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index d840329..1d6f3f3 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -38,9 +38,9 @@ jobs: with: go-version-file: ./go.mod - name: golangci-lint - uses: golangci/golangci-lint-action@1481404843c368bc19ca9406f87d6e0fc97bdcfd #v7.0.0 + uses: golangci/golangci-lint-action@55c2c1448f86e01eaae002a5a3a9624417608d84 v6.5.2 with: - version: v2.1.5 + version: v1.62.0 skip-cache: true install-mode: binary codegen: From a65bb57b1881c3158409f1b3603643a800116411 Mon Sep 17 00:00:00 2001 From: Gabriel Mabille Date: Wed, 30 Apr 2025 15:44:15 +0200 Subject: [PATCH 5/5] Forgot # --- .github/workflows/go.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 1d6f3f3..3ed4ea8 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -38,7 +38,7 @@ jobs: with: go-version-file: ./go.mod - name: golangci-lint - uses: golangci/golangci-lint-action@55c2c1448f86e01eaae002a5a3a9624417608d84 v6.5.2 + uses: golangci/golangci-lint-action@55c2c1448f86e01eaae002a5a3a9624417608d84 #v6.5.2 with: version: v1.62.0 skip-cache: true