Correctly display events and links for table view queries - #1345
Merged
Merged
Conversation
|
|
mcorbin
force-pushed
the
fix-table-events-link
branch
from
August 19, 2025 12:56
32dcac7 to
0004bd6
Compare
Fix grafana#1262 Pass the events and links configuration to the query and use otel columns if opentelemetry is enabled. This allows displaying events to the trace panel.
adamyeats
force-pushed
the
fix-table-events-link
branch
from
August 29, 2025 17:25
60a9e19 to
52f9e87
Compare
adamyeats
previously approved these changes
Sep 1, 2025
adamyeats
left a comment
adamyeats
left a comment
Contributor
There was a problem hiding this comment.
LGTM! One minor comment below.
adamyeats
approved these changes
Sep 4, 2025
github-project-automation
Bot
moved this from Needs Review
to Done
in Partner Datasources
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1262
Pass the events and links configuration to the query and use otel columns if opentelemetry is enabled.
This allows displaying events in the trace panel.
I tested it locally: the events are correctly displayed when coming from a table trace ID.