This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Adds a label names API #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
commented
Sep 2, 2022
| @@ -31,6 +31,8 @@ export function QueryEditor(props: Props) { | |||
| useMount(async () => { | |||
| const profileTypes = await props.datasource.getProfileTypes(); | |||
| setProfileTypes(profileTypes); | |||
| // todo remove me. | |||
| console.log(await props.datasource.getLabelNames()); | |||
There was a problem hiding this comment.
@joey-grafana This is how to use it, we should probably do this on demand when trying to select name.
simonswine
approved these changes
Sep 2, 2022
pkg/firedb/head.go
Outdated
Comment on lines
363
to
365
| result := lo.Reject(values, func(name string, _ int) bool { | ||
| return strings.HasPrefix(name, "__") | ||
| }) |
There was a problem hiding this comment.
I am not too sure about this, e.g. prometheus returns _name_ on the equivalent endpoint.
$ curl -s https://prometheus.demo.do.prometheus.io/api/v1/labels | jq .
{
"status": "success",
"data": [
"__name__",
"action",
"address",
[...]
There was a problem hiding this comment.
ok may be we can leave it ?
There was a problem hiding this comment.
I'll leave them they should be filtered out by the UI though @joey-grafana anything that start with __ should not be shown on the ui.
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
Adds a label names API
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a label names API to fire and the datasource too.