Repository navigation
ci: zizmor fixes - #1977
Merged
Merged
ci: zizmor fixes#1977
Conversation
theSuess
requested review from
Baarsgaard,
hubeadmin,
ishanjainn,
nissessenap,
pb82 and
weisdd
as code owners
April 28, 2025 12:09
theSuess
commented
Apr 28, 2025
weisdd
requested changes
Apr 28, 2025
Baarsgaard
approved these changes
Apr 28, 2025
Baarsgaard
left a comment
Baarsgaard
left a comment
Collaborator
There was a problem hiding this comment.
There's less changes than I expected!
Is it possible to run the actions before we merge?
Even if it just verifies that all the commit hashes are valid?
Collaborator
Author
|
I've manually cross-referenced all commit hashes so they should be good. When the security team comes around to reviewing our repo, they'll re-enable actions and they'll run for this PR before merging |
weisdd
approved these changes
Apr 29, 2025
theSuess
force-pushed
the
ci/zizmor-fixes
branch
from
April 29, 2025 11:48
15444c0 to
de1a0b5
Compare
Collaborator
Author
|
thanks for fixing the outstanding issue @Baarsgaard ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes potential security issues discovered using zizmor.
It also pins all actions used to a hash version to prevent any hostile takeovers of external dependencies.