From aeb64ecb168b22c589df9d8cfb25909e4c5ee8ad Mon Sep 17 00:00:00 2001 From: Leon Sorokin Date: Thu, 15 Apr 2021 05:27:28 -0500 Subject: [PATCH] GraphNG: use theme font family and size for axis labels (#33009) * GraphNG: use theme font family and size for axis labels * fix test --- .../src/components/uPlot/config/UPlotAxisBuilder.ts | 8 ++++++-- .../uPlot/config/UPlotConfigBuilder.test.ts | 13 ++++++------- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/packages/grafana-ui/src/components/uPlot/config/UPlotAxisBuilder.ts b/packages/grafana-ui/src/components/uPlot/config/UPlotAxisBuilder.ts index b200ae218795..c4aaac4d9c7b 100644 --- a/packages/grafana-ui/src/components/uPlot/config/UPlotAxisBuilder.ts +++ b/packages/grafana-ui/src/components/uPlot/config/UPlotAxisBuilder.ts @@ -50,6 +50,10 @@ export class UPlotAxisBuilder extends PlotConfigBuilder { theme, } = this.props; + let { typography } = theme; + + let font = `${typography.size.sm} ${typography.fontFamily.sansSerif}`; + const gridColor = theme.isDark ? theme.palette.gray25 : theme.palette.gray90; let config: Axis = { @@ -57,8 +61,8 @@ export class UPlotAxisBuilder extends PlotConfigBuilder { show, stroke: theme.colors.text, side: getUPlotSideFromAxis(placement), - font: `12px 'Roboto'`, - labelFont: `12px 'Roboto'`, + font, + labelFont: font, size: this.props.size ?? calculateAxisSize, gap, grid: { diff --git a/packages/grafana-ui/src/components/uPlot/config/UPlotConfigBuilder.test.ts b/packages/grafana-ui/src/components/uPlot/config/UPlotConfigBuilder.test.ts index ad911915f3ed..6209487e89e0 100644 --- a/packages/grafana-ui/src/components/uPlot/config/UPlotConfigBuilder.test.ts +++ b/packages/grafana-ui/src/components/uPlot/config/UPlotConfigBuilder.test.ts @@ -1,7 +1,6 @@ // TODO: migrate tests below to the builder import { UPlotConfigBuilder } from './UPlotConfigBuilder'; -import { GrafanaTheme } from '@grafana/data'; import { GraphGradientMode, AxisPlacement, @@ -292,7 +291,7 @@ describe('UPlotConfigBuilder', () => { formatValue: () => 'test value', grid: false, show: true, - theme: { isDark: true, palette: { gray25: '#ffffff' }, colors: { text: 'gray' } } as GrafanaTheme, + theme: darkTheme, values: [], }); @@ -300,15 +299,15 @@ describe('UPlotConfigBuilder', () => { Object { "axes": Array [ Object { - "font": "12px 'Roboto'", + "font": "12px 'Inter', 'Helvetica Neue', Arial, sans-serif", "gap": 5, "grid": Object { "show": false, - "stroke": "#ffffff", + "stroke": "#2c3235", "width": 1, }, "label": "test label", - "labelFont": "12px 'Roboto'", + "labelFont": "12px 'Inter', 'Helvetica Neue', Arial, sans-serif", "labelSize": 18, "scale": "scale-x", "show": true, @@ -316,10 +315,10 @@ describe('UPlotConfigBuilder', () => { "size": [Function], "space": [Function], "splits": undefined, - "stroke": "gray", + "stroke": "rgba(255, 255, 255, 0.77)", "ticks": Object { "show": true, - "stroke": "#ffffff", + "stroke": "#2c3235", "width": 1, }, "timeZone": "browser",