New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added concentration units #11211

Closed
flopp999 opened this Issue Mar 12, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@flopp999
Contributor

flopp999 commented Mar 12, 2018

I have never been using Github to help creating code, so please tell me if I am doing something wrong.

I will try to add more units to Grafana, I will add below units

We are measuring gases and we use a lot of different units for this:
ppm
ppb
ng/m3
ng/Nm3
μg/m3
μg/Nm3
mg/m3
mg/Nm3
g/m3
g/Nm3
Nm3

all N above means Normal cubic meter, which is normalized(NTP)

@bergquist

This comment has been minimized.

Show comment
Hide comment
@bergquist

bergquist Mar 13, 2018

Contributor

Closed by #11212

Contributor

bergquist commented Mar 13, 2018

Closed by #11212

@bergquist bergquist closed this Mar 13, 2018

@bergquist bergquist added this to the 5.1 milestone Mar 13, 2018

marefr added a commit that referenced this issue Apr 16, 2018

marefr added a commit that referenced this issue Apr 27, 2018

revert renaming of unit key ppm
#11211 removed the unit key ppm in favor of conppm. A change which is not forward compatible.
This commit revert the unit key back to ppm.
Also adds some better error description if trying to use a unit which don't exists.
Fixes #11743
@shred

This comment has been minimized.

Show comment
Hide comment
@shred

shred May 5, 2018

Thank you for adding these units. I really missed µg/m³ for my particulates sensor...

Can you use a superscript 3 ( ³ ) for cubic? A normal 3 looks just wrong here, it hurts my eyes. 😉

shred commented May 5, 2018

Thank you for adding these units. I really missed µg/m³ for my particulates sensor...

Can you use a superscript 3 ( ³ ) for cubic? A normal 3 looks just wrong here, it hurts my eyes. 😉

@flopp999

This comment has been minimized.

Show comment
Hide comment
@flopp999

flopp999 May 7, 2018

Contributor

Nice to hear that someone use it more than myself
I had the same thought but I looked at square meters and the superscript 2 was really small and difficult to see.
Can you check square meters unit and reply what you think about my thought?

Contributor

flopp999 commented May 7, 2018

Nice to hear that someone use it more than myself
I had the same thought but I looked at square meters and the superscript 2 was really small and difficult to see.
Can you check square meters unit and reply what you think about my thought?

marefr added a commit that referenced this issue May 7, 2018

revert renaming of unit key ppm
#11211 removed the unit key ppm in favor of conppm. A change which is not forward compatible.
This commit revert the unit key back to ppm.
Also adds some better error description if trying to use a unit which don't exists.
Fixes #11743

(cherry picked from commit 138c8c3)
@shred

This comment has been minimized.

Show comment
Hide comment
@shred

shred May 7, 2018

IMHO I wouldn't think too much about the readability. m³ is the official SI notation, and it is consistent to the other notations used in Grafana (like m², ft² or sec²). One could use the browser zoom to enhance readability.

shred commented May 7, 2018

IMHO I wouldn't think too much about the readability. m³ is the official SI notation, and it is consistent to the other notations used in Grafana (like m², ft² or sec²). One could use the browser zoom to enhance readability.

@flopp999

This comment has been minimized.

Show comment
Hide comment
@flopp999

flopp999 May 9, 2018

Contributor

@shred I am just about to change to ³.
Do you see any other unit that have 3 instead of ³.
I found Nm3, dm3 and m3.
What do you think about Feet/sec², would that be "Feet/s²"?

Contributor

flopp999 commented May 9, 2018

@shred I am just about to change to ³.
Do you see any other unit that have 3 instead of ³.
I found Nm3, dm3 and m3.
What do you think about Feet/sec², would that be "Feet/s²"?

@shred

This comment has been minimized.

Show comment
Hide comment
@shred

shred May 9, 2018

I have found no other units than the one you have found already.

About the seconds... According to SI, the correct notation would be s², not sec².

shred commented May 9, 2018

I have found no other units than the one you have found already.

About the seconds... According to SI, the correct notation would be s², not sec².

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment