New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] User with org viewer role should not be able to save/move dashboards in/to general folder #11553

Closed
marefr opened this Issue Apr 10, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@marefr
Member

marefr commented Apr 10, 2018

What Grafana version are you using?

latest master

What did you do?

  • User has org viewer role.
  • User have been granted editor or admin permission for a folder
  • User open an existing dashboard under the folder he has editor/admin role
  • Open “Settings”
  • Change folder to “General”
  • Clicks on “Save”

What was the expected result?

Message: Access denied to save dashboard

What happened instead?

Dashboard successfully saved and moved to General folder. User can’t go to “General” folder to move the dashboard back (since he’s only a “viewer” at Org level).
Note that if the user try to create a brand new dashboard into “General” folder, it will get “access denied”.

Also, if users moves a dashboard from folder he has editor/admin role to General folder it is allowed. Expected result is Access denied to save dashboard .

@marefr marefr changed the title from [Bug] User with org viewer role should not be able to save dashboards in general folder to [Bug] User with org viewer role should not be able to save/move dashboards in/to general folder Apr 10, 2018

@marefr marefr self-assigned this Apr 10, 2018

@marefr marefr added this to the 5.1 milestone Apr 11, 2018

@daniellee daniellee closed this in #11554 Apr 17, 2018

daniellee added a commit that referenced this issue Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment