New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Annotation limit showing wrong #11569

Closed
flopp999 opened this Issue Apr 12, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@flopp999
Contributor

flopp999 commented Apr 12, 2018

What Grafana version are you using?

5.0.4

What datasource are you using?

Influx

What OS are you running grafana on?

Debian

Creating a new 15 graphs in a dashboard, setting up alert on each graph.
One day there should have been an alert on each graph, which I could see because the heart was red.
But I only had the red lert annotation line in 10 graphs, it should have been in all of them.
Checking settings and it was set to 100 annotations, I know that something a setting can show wrong so I changed it to 50 and directly I could see all 15 annotations as I was expecting.

So it seems to be set to 10 but in the setting it shows 100 as default

@torkelo

This comment has been minimized.

Show comment
Hide comment
@torkelo

torkelo Apr 12, 2018

Member

thanks for reporting this, it appears the 100 limit is only defined in the UI when you create new annotations (or modify the existing auto generated one).

The backend query default is 10:
https://github.com/grafana/grafana/blob/master/pkg/services/sqlstore/annotation.go#L205

Easiest fix would be to change the backend default to also be 100

Member

torkelo commented Apr 12, 2018

thanks for reporting this, it appears the 100 limit is only defined in the UI when you create new annotations (or modify the existing auto generated one).

The backend query default is 10:
https://github.com/grafana/grafana/blob/master/pkg/services/sqlstore/annotation.go#L205

Easiest fix would be to change the backend default to also be 100

@torkelo torkelo added this to the 5.1 milestone Apr 12, 2018

@marefr marefr closed this Apr 13, 2018

marefr added a commit that referenced this issue Apr 13, 2018

marefr added a commit that referenced this issue Apr 13, 2018

marefr added a commit that referenced this issue Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment