New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus query inspector expands to be very large on autocomplete queries #11673

Closed
nikoalch opened this Issue Apr 20, 2018 · 0 comments

Comments

Projects
None yet
3 participants
@nikoalch
Contributor

nikoalch commented Apr 20, 2018

What Grafana version are you using?

Hosted Grafana

What datasource are you using?

MT

I hit a grafana + prometheus bug while the query inspector is open. It's pretty reproducible:

  1. create a new graph
  2. have the query inspector open
  3. start typing
  4. the query inspector returns a huge list of metrics
  5. finish typing
  6. your canvas (at least in FF) ends up being insanely large

@davkal davkal self-assigned this Apr 20, 2018

davkal added a commit that referenced this issue Apr 20, 2018

Add silent option to backend requests
* When set to `true`, the `silent` option for backend_srv requests
 suppresses all event emitters that are triggered when the response is
received.
* Added `helperRequest()` to the Prometheus datasource to support
 requests that are not triggered by the user, e.g., for tab completion.
`helperRequest()` sets the `silent` option.
* Migrated all non-timeseries queries of the Prometheus datasource to
 use `helperRequest()`.

Fixes #11673

@davkal davkal closed this in #11678 Apr 25, 2018

@marefr marefr modified the milestones: 5.2, 5.1 Apr 25, 2018

marefr added a commit that referenced this issue Apr 26, 2018

Add silent option to backend requests
* When set to `true`, the `silent` option for backend_srv requests
 suppresses all event emitters that are triggered when the response is
received.
* Added `helperRequest()` to the Prometheus datasource to support
 requests that are not triggered by the user, e.g., for tab completion.
`helperRequest()` sets the `silent` option.
* Migrated all non-timeseries queries of the Prometheus datasource to
 use `helperRequest()`.

Fixes #11673

(cherry picked from commit 53817b7)

@daniellee daniellee changed the title from Grafana and Prometheus Query inspector bug to Prometheus query inspector expands to be very large on autocomplete queries Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment