New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.1.0 - AppVeyor Windows build missing version and commit info #11758

Closed
daniellee opened this Issue Apr 27, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@daniellee
Member

daniellee commented Apr 27, 2018

The Appveyor build does not set the version and commit info when building binaries anymore. When running go build.go build locally on Windows it does get the correct info.

AppVeyor is running Go version 1.10 and Windows Server 2012.

In the logs:

INFO[04-27|15:09:57] Starting Grafana                         logger=server version=5.0.0 commit=NA compiled=2018-04-27T15:09:57+0200

And in the Grafana footer:

image

@daniellee

This comment has been minimized.

Show comment
Hide comment
@daniellee

daniellee Apr 27, 2018

Member

Seems to be this problem: https://go-review.googlesource.com/c/go/+/109235

I could recreate this locally on Windows 10 by changing all the letters to be lowercase in the GOPATH env variable. Need to do some debugging work to figure out the result of the call to os.Getwd on the AppVeyor server and see which letters are uppercase.

Member

daniellee commented Apr 27, 2018

Seems to be this problem: https://go-review.googlesource.com/c/go/+/109235

I could recreate this locally on Windows 10 by changing all the letters to be lowercase in the GOPATH env variable. Need to do some debugging work to figure out the result of the call to os.Getwd on the AppVeyor server and see which letters are uppercase.

daniellee added a commit that referenced this issue Apr 27, 2018

@daniellee daniellee closed this in 7e2fb5e Apr 27, 2018

daniellee added a commit that referenced this issue Apr 27, 2018

appveyor: uppercase the C drive in go path
Fixes #11758

(cherry picked from commit 7e2fb5e)

daniellee added a commit that referenced this issue May 3, 2018

ryantxu added a commit to NatelEnergy/grafana that referenced this issue May 4, 2018

Merge remote-tracking branch 'grafana/master'
* grafana/master:
  changelog: add notes about closing #11616
  fixed text color in light theme
  changelog: add notes about closing #11800
  test if default variable interpolation is effective when no specific format is specified
  changelog: notes about closing #11690
  changelog: add notes for ##11754, #11758, #11710
  scroll: remove firefox scrollbars
  dont shadow format passed in as function parameter
  Metrics package now follows new service interface & registration (#11787)
  scroll: fix scrolling on mobile Chrome (#11710)
  fixed so all buttons are styled not just small ones, fixes #11616
  add test for prometheus table column title
  increase length of auth_id column in user_auth table
  fix to match table column name and order

ryantxu added a commit to ryantxu/grafana that referenced this issue May 7, 2018

Merge remote-tracking branch 'grafana/master' into dashboard-panels
* grafana/master: (531 commits)
  Update ROADMAP.md
  support additional fields in authproxy (#11661)
  better handling for special chars in db config (#11662)
  Fix/improved csv output (#11740)
  Update ROADMAP.md
  Update ROADMAP.md
  Update ROADMAP.md
  Remove preceding `/` from public JS path (#11804)
  Add panel scrolling docs (#11826)
  escape pipe symbol same way as in templating docs
  changelog: add notes about closing #11616
  added left:unset to counter left:0 in recent react-select release
  fixed text color in light theme
  changelog: add notes about closing #11800
  test if default variable interpolation is effective when no specific format is specified
  changelog: notes about closing #11690
  changelog: add notes for ##11754, #11758, #11710
  scroll: remove firefox scrollbars
  Add missing items to Gopkg.lock
  pipe escape try #3
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment