Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasource selection in panel by enter key no longer works #13932

Closed
torkelo opened this issue Nov 1, 2018 · 3 comments · Fixed by #13977
Closed

Datasource selection in panel by enter key no longer works #13932

torkelo opened this issue Nov 1, 2018 · 3 comments · Fixed by #13977
Labels
prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@torkelo
Copy link
Member

torkelo commented Nov 1, 2018

Selecting values in the metric segment lookup no longer works with enter key.

@torkelo torkelo added the prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Nov 1, 2018
@torkelo torkelo added this to the 5.3.3 milestone Nov 1, 2018
@torkelo
Copy link
Member Author

torkelo commented Nov 1, 2018

I think this was caused by this PR: #13670

@marefr
Copy link
Member

marefr commented Nov 5, 2018

Following change seems to solve selecting by enter key in the datasource selector:

diff --git a/public/app/core/components/form_dropdown/form_dropdown.ts b/public/app/core/components/form_dropdown/form_dropdown.ts
index 6e863e1..81d4b33 100644
--- a/public/app/core/components/form_dropdown/form_dropdown.ts
+++ b/public/app/core/components/form_dropdown/form_dropdown.ts
@@ -88,7 +88,7 @@ export class FormDropdownCtrl {
       if (evt.keyCode === 13) {
         setTimeout(() => {
           this.inputElement.blur();
-        }, 100);
+        }, 300);
       }
     });

@marefr
Copy link
Member

marefr commented Nov 5, 2018

Not been able to reproduce using graphite query editor. Should function drop down selector work with keyboard up/down/enter? It doesn't.

@marefr marefr changed the title metric segment selecting by enter key no longer works Datasource selection in panel by enter key no longer works Nov 6, 2018
marefr added a commit that referenced this issue Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants