Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS: Option to disable or sanitize html source in some panels #15293

Closed
noasand opened this issue Feb 7, 2019 · 4 comments
Closed

XSS: Option to disable or sanitize html source in some panels #15293

noasand opened this issue Feb 7, 2019 · 4 comments

Comments

@noasand
Copy link

noasand commented Feb 7, 2019

Grafana is vulnerable to XSS vulnerability because the panels included in the description below can contain html. Therefore, the option to disable or filter the html source must be provided.

[Affected Component]
#Grafana(5.3.1)
Dashboard > Text Panel

[Attack Vectors]

  1. Grafana(5.3.1) Launch
  2. Access to any dashboard
  3. Add Panel > Text
  4. Edit Text Panel
  5. Set Options -> Mode(html) & Content(<script>alert('XSS');</script>)

[Affected Component]
#Grafana(5.3.1)
Dashboard > Table Panel

[Attack Vectors]

  1. Grafana(5.3.1) Launch
  2. Access to any dashboard
  3. Add Panel > Table
  4. Edit Table Panel
  5. Set Column Styles
    : Check Render value as link
    : set Url(javascript:alert('XSS'))

[Affected Component]
#Grafana(5.3.1)
Dashboard > All Panels > General

[Attack Vectors]

  1. Grafana(5.3.1) Launch
  2. Access to any dashboard
  3. Dashboard Settings
  4. Set dashboard name(TEST<script>alert('XSS')</script>
  5. Save dashboard and go back to dashboard home
  6. Edit any panel
  7. Add link, in General
  8. Write the 'TEST' on the dashboard blank
@noasand
Copy link
Author

noasand commented Feb 7, 2019

This issue is associated with #4117.

@torkelo
Copy link
Member

torkelo commented Feb 7, 2019

Yes, which we fixed in upcoming v6 (out in beta). From now on html will be. Sanitized by default in text panel

@torkelo torkelo closed this as completed Feb 7, 2019
@noasand
Copy link
Author

noasand commented Jun 4, 2019

Please check whether the above three vulnerabilities have been fixed in v6.

@noasand
Copy link
Author

noasand commented Nov 6, 2019

Hello. I have confirmed that the first vulnerability has been fixed. Please let me know if the other two are corrected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants