When selecting a timespan of 30 days and 8 days is returned; we still draw the space for 1 month #272

Closed
damm opened this Issue Apr 1, 2014 · 16 comments

Projects

None yet

2 participants

@damm
Contributor
damm commented Apr 1, 2014

I just became aware of the limitation of Flot only rendering 8 days of data. I suspect we should fix the timepicker so it shows that as the maximum.

Makes rendering also rather ugly as we're drawing space for metrics that do not get drawn there.

screen shot 2014-04-01 at 3 14 58 pm

@torkelo
Member
torkelo commented Apr 2, 2014

I am sorry but I do not understand. Flot has NO such limitation. You can select ANY time range, and grafana will fetch data from graphite and render it with flot. If there is only data in graphite for part of the time range only a part of the graph will have data. Are you sure there is data in your graphite server that extend beyond 8 days for the above metrics?

@torkelo torkelo added the question label Apr 2, 2014
@damm
Contributor
damm commented Apr 2, 2014

I cannot get more than 2 months of data today. So I am assuming I could have a few damaged whisper files. However the rendering bug still stands here.

screen shot 2014-04-02 at 12 01 39 pm

Where in Grafana it renders data it has no data from.

P.S. I'm running the 0.9.x branch of graphite (it's about 2 months old) so the data was there yesterday I could be hitting some bug that I need to dig into more.

I updated the subject of the issue, as the original subject was wrong.

@damm damm changed the title from Timepicker should be aware of Rendering limitations to When selecting a timespan of 30 days and 8 days is returned; we still draw the space for 1 month Apr 2, 2014
@torkelo
Member
torkelo commented Apr 2, 2014

In display setting you can switch to png renderer to compare flot with graphite png renderer

@damm
Contributor
damm commented Apr 2, 2014

Note the data's changed a bit and the whisper file had a corrupt spot 8 days ago which is why it's showing what it is. I should really figure out what caused that; kinda creepy :/

We keep 10s for 14days, so loosing data at 8 days is really bad.

screen shot 2014-04-02 at 4 23 03 pm

@torkelo
Member
torkelo commented Apr 3, 2014

@damm ok, so I can close this?

@damm
Contributor
damm commented Apr 3, 2014

I still think that drawing that empty space is a bug in Grafana. We don't render that empty space in Flot; nor in PNG. We do in Grafana. :(

Don't you agree that Grafana should be rendering the same data (and to the proper span) that Graphite renders?

@torkelo
Member
torkelo commented Apr 3, 2014

@damm I do not understand. I get the same result in graphite png renderer as in flot.

image

image

Graphites png renderer shows the time range you request no matter if there is data there or not. Or am I missunderstanding your case?

@torkelo
Member
torkelo commented Apr 3, 2014

I mean what your are saying is strange. Empty space? You have a time range. Just because there is no data should we change it? What if there is data on some other graph? It would be very inconsistent and confusing when comparing graphs. Is there a setting in graphite that makes it behave like this? Seems very odd.

@damm
Contributor
damm commented Apr 4, 2014

I am referring to the empty space in
screen shot 2014-04-01 at 3 14 58 pm

Flot of the same timespan does not produce this same artifact

screen shot 2014-04-02 at 12 01 39 pm

Why does flot render it with the full span and Grafana renders the same data in a quarter of the space?

@torkelo
Member
torkelo commented Apr 4, 2014

@damm it must be a bug in the version of Graphite flot you have.

I do not get the that behavior. For me it shows the time range I have chosen.
image

Graphites png renderer behaves the same (shows the time range you choose). The behavior you are wishing for would be VERY confusing and make comparing graphs very difficult. I mean in a dashboard you often have some graphs (like errors, infrequent event counters) that have no data for a period, but you want to be able to match the timeline to other graphs easily. It would be very strange to reduce the time axis to only fit the data that exists.

@torkelo torkelo closed this Apr 4, 2014
@torkelo torkelo added the wontfix label Apr 4, 2014
@damm
Contributor
damm commented Apr 4, 2014

@torkelo i'll update my graphite but this behavior is quite confusing as well. When Flot renders it one way; and Grafana renders it another way the blame unfortunately gets set on Grafana incorrectly.

Hope I can fix this :/ has turned into a black eye for me

@torkelo
Member
torkelo commented Apr 4, 2014

@damm yes that is unfortunate, and I understand that is confusing that they show different results. But I think it is clear that your graphite flot results are buggy. What version of graphite are you using? For me both png graphite renderer and graphites experimental flot renderer match the grafana graph (tested both 0.9.12 and 0.9.x branch).

@damm
Contributor
damm commented Apr 4, 2014

I run the 0.9.x branch (about 2months old) so it's 0.9.12. There has not been many commits recently to warrant updating it.

@damm
Contributor
damm commented Apr 6, 2014

@torkelo just for reference.

I've updated graphite-web to the latest commit in 0.9.x as well as re-creating the files (updating grafana) and am still able to reproduce this perfectly.

Using graphite-api seems to happen as well, tried resizing them and no change so i'm going to nuke some and let them get recreated and hope this gets fixed.

@torkelo
Member
torkelo commented Apr 6, 2014

@damm that is strange. Do get the same behavior in graphite native png renderer?

@damm
Contributor
damm commented Apr 6, 2014

@torkelo after the update yes. With graphite-api the flot and png renderer match. So at least now I can say I am getting the same results all over and they are all the same.

I resized my wsp so I hope I can get more than 8 days of data soon.

@Dieterbe Dieterbe pushed a commit to Dieterbe/grafana that referenced this issue Jul 7, 2015
@woodsaj woodsaj remove extra comma. fixes #272 4a9d771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment