Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerting: Need better regression tests for DTO conversions #53689

Open
alexweav opened this issue Aug 12, 2022 · 0 comments
Open

Alerting: Need better regression tests for DTO conversions #53689

alexweav opened this issue Aug 12, 2022 · 0 comments
Labels
area/alerting Grafana Alerting internal for issues made by grafanistas prio/low It's a good idea, but not scheduled for any release type/debt technical debt

Comments

@alexweav
Copy link
Contributor

alexweav commented Aug 12, 2022 •
edited by armandgrillet

Unified Alerting has a lot of Data Transfer Objects (DTOs), in some cases we have separate DTOs for the same object (prom vs DB vs API, etc).

We write functions to convert between DTOs representing the same concept, but these functions often are not deeply tested on every field. These conversion functions are a common source of type mapping bugs. We should ensure that our DTO conversions are properly tested and assert on every field.
@alexweav alexweav added area/alerting Grafana Alerting type/debt technical debt labels Aug 12, 2022
@alexweav alexweav mentioned this issue Aug 12, 2022
Merged
@armandgrillet armandgrillet added the prio/low It's a good idea, but not scheduled for any release label Aug 19, 2022
@armandgrillet armandgrillet added the internal for issues made by grafanistas label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/alerting Grafana Alerting internal for issues made by grafanistas prio/low It's a good idea, but not scheduled for any release type/debt technical debt
Projects
Alerting
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@armandgrillet @alexweav