New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Integration with HipChat #6451

Closed
Gelob opened this Issue Nov 2, 2016 · 10 comments

Comments

Projects
None yet
7 participants
@Gelob

Gelob commented Nov 2, 2016

  • I'm submitting a ...
  • Bug report
  • Feature request
  • Question / Support request: Would love to see notification support for sending to HipChat via API v2.
@alexzorin

This comment has been minimized.

Show comment
Hide comment
@alexzorin

alexzorin Nov 8, 2016

Hi,

Anybody working on this? I will be needing it at $employer, so I've hacked together a branch to get things started.

Here it is: master...alexzorin:hipchat_alerting

I'm not too keen on taking on the whole feature myself, so if anybody else wants to jump on (or is already doing it in parallel) that would be super.

It uses the v2 API to send an 'Application'-style card notification.

Unfortunately I had to mess with Grafana a little bit so I could set Content-Type header in webhook request - sorry!

Here's how it looks in the client:

screeny

alexzorin commented Nov 8, 2016

Hi,

Anybody working on this? I will be needing it at $employer, so I've hacked together a branch to get things started.

Here it is: master...alexzorin:hipchat_alerting

I'm not too keen on taking on the whole feature myself, so if anybody else wants to jump on (or is already doing it in parallel) that would be super.

It uses the v2 API to send an 'Application'-style card notification.

Unfortunately I had to mess with Grafana a little bit so I could set Content-Type header in webhook request - sorry!

Here's how it looks in the client:

screeny

@utkarshcmu

This comment has been minimized.

Show comment
Hide comment
@utkarshcmu

utkarshcmu Nov 8, 2016

Contributor

@bergquist I think if we can make a branch alerting_hipchat and merge @alexzorin work in there, it would be a great start! 👍

Contributor

utkarshcmu commented Nov 8, 2016

@bergquist I think if we can make a branch alerting_hipchat and merge @alexzorin work in there, it would be a great start! 👍

@dinoocch

This comment has been minimized.

Show comment
Hide comment
@dinoocch

dinoocch Nov 15, 2016

@alexzorin It'd be nice if we could send graphs as well. This is some python code that I'm using to do something similar. I haven't had a chance to poke at the grafana http alert code yet, but I believe the slack endpoint has this functionality (although slack presents a much more standard api...)

https://api.hipchat.com/v2/room/{room}/share/file endpoint per the documentation

dinoocch commented Nov 15, 2016

@alexzorin It'd be nice if we could send graphs as well. This is some python code that I'm using to do something similar. I haven't had a chance to poke at the grafana http alert code yet, but I believe the slack endpoint has this functionality (although slack presents a much more standard api...)

https://api.hipchat.com/v2/room/{room}/share/file endpoint per the documentation

@alexzorin

This comment has been minimized.

Show comment
Hide comment
@alexzorin

alexzorin Nov 15, 2016

@dinoocch I agree, the graph would be nice. The icon in the screenshot is actually the graph, haha (but useless because it's just a thumb).

I struggled to figure out how to do it in a single 'message'. There is a 'media'-style card where we could send the graph but then we cannot send the metrics data.

/share/file can be sent with a message, but I am not sure whether it can be sent with a card.

alexzorin commented Nov 15, 2016

@dinoocch I agree, the graph would be nice. The icon in the screenshot is actually the graph, haha (but useless because it's just a thumb).

I struggled to figure out how to do it in a single 'message'. There is a 'media'-style card where we could send the graph but then we cannot send the metrics data.

/share/file can be sent with a message, but I am not sure whether it can be sent with a card.

@utkarshcmu

This comment has been minimized.

Show comment
Hide comment
@utkarshcmu

utkarshcmu Nov 16, 2016

Contributor

I ll try to work on HipChat alerting here https://github.com/utkarshcmu/grafana/tree/alerting_hipchat
and will submit a PR asap.

Contributor

utkarshcmu commented Nov 16, 2016

I ll try to work on HipChat alerting here https://github.com/utkarshcmu/grafana/tree/alerting_hipchat
and will submit a PR asap.

@bergquist

This comment has been minimized.

Show comment
Hide comment
@bergquist

bergquist Jan 2, 2017

Contributor

alerting_hipchat branch is open. Please create Pull requests to that branch.

Contributor

bergquist commented Jan 2, 2017

alerting_hipchat branch is open. Please create Pull requests to that branch.

@jregovic

This comment has been minimized.

Show comment
Hide comment
@jregovic

jregovic Jan 25, 2017

Contributor

hipchatnot

Contributor

jregovic commented Jan 25, 2017

hipchatnot

@jregovic

This comment has been minimized.

Show comment
Hide comment
@jregovic

jregovic Jan 26, 2017

Contributor

I think I stuffed it on the pull request. Should I just redo the whole thing?

Contributor

jregovic commented Jan 26, 2017

I think I stuffed it on the pull request. Should I just redo the whole thing?

@lbrictson

This comment has been minimized.

Show comment
Hide comment
@lbrictson

lbrictson Jan 26, 2017

+1 for this feature! Very excited

lbrictson commented Jan 26, 2017

+1 for this feature! Very excited

@bergquist

This comment has been minimized.

Show comment
Hide comment
@bergquist

bergquist Feb 8, 2017

Contributor

Closed by #7484

Contributor

bergquist commented Feb 8, 2017

Closed by #7484

@bergquist bergquist closed this Feb 8, 2017

@bergquist bergquist modified the milestones: 4.2.0, 4.2.0-beta1 Feb 8, 2017

bergquist added a commit that referenced this issue Feb 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment