[Cloudwatch] Make it possible to specify access and secret key on the data source config page #6697

Closed
bergquist opened this Issue Nov 24, 2016 · 4 comments

Projects

None yet

2 participants

@bergquist
Contributor

Makes it easier to start using the cloudwatch plugin and users wont require access to the server running Grafana.

@bergquist bergquist added this to the 4.1.0 milestone Nov 24, 2016
@bergquist bergquist self-assigned this Nov 24, 2016
@bergquist bergquist closed this in 7bc1c3c Nov 29, 2016
@torkelo
Member
torkelo commented Dec 14, 2016

this seems very broken, Cloudwatch plugin edit page does not load :(

js error, no encryptedFields on new/empty data source model. When did change from json secureJsonData?

@torkelo
Member
torkelo commented Dec 14, 2016

this is strange, frontend is still using seureJsonData but backend expects encryptedFields

@torkelo
Member
torkelo commented Dec 14, 2016

I do not understand the encryptedFields thing and TLSAuth, on the Datasource dto. They seem to both serve the same purpose of informing frontend of what encrypted properties have values.

https://github.com/grafana/grafana/blob/master/pkg/api/dtos/models.go#L84

@torkelo
Member
torkelo commented Dec 14, 2016

think I found a simple way to refactor encrytedFields and TLSAuth into a secureJsonFields map[string]bool
330c1b9

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment