New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloudwatch] Make it possible to specify access and secret key on the data source config page #6697

Closed
bergquist opened this Issue Nov 24, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@bergquist
Contributor

bergquist commented Nov 24, 2016

Makes it easier to start using the cloudwatch plugin and users wont require access to the server running Grafana.

@torkelo

This comment has been minimized.

Show comment
Hide comment
@torkelo

torkelo Dec 14, 2016

Member

this seems very broken, Cloudwatch plugin edit page does not load :(

js error, no encryptedFields on new/empty data source model. When did change from json secureJsonData?

Member

torkelo commented Dec 14, 2016

this seems very broken, Cloudwatch plugin edit page does not load :(

js error, no encryptedFields on new/empty data source model. When did change from json secureJsonData?

@torkelo

This comment has been minimized.

Show comment
Hide comment
@torkelo

torkelo Dec 14, 2016

Member

this is strange, frontend is still using seureJsonData but backend expects encryptedFields

Member

torkelo commented Dec 14, 2016

this is strange, frontend is still using seureJsonData but backend expects encryptedFields

@torkelo

This comment has been minimized.

Show comment
Hide comment
@torkelo

torkelo Dec 14, 2016

Member

I do not understand the encryptedFields thing and TLSAuth, on the Datasource dto. They seem to both serve the same purpose of informing frontend of what encrypted properties have values.

https://github.com/grafana/grafana/blob/master/pkg/api/dtos/models.go#L84

Member

torkelo commented Dec 14, 2016

I do not understand the encryptedFields thing and TLSAuth, on the Datasource dto. They seem to both serve the same purpose of informing frontend of what encrypted properties have values.

https://github.com/grafana/grafana/blob/master/pkg/api/dtos/models.go#L84

@torkelo

This comment has been minimized.

Show comment
Hide comment
@torkelo

torkelo Dec 14, 2016

Member

think I found a simple way to refactor encrytedFields and TLSAuth into a secureJsonFields map[string]bool
330c1b9

:)

Member

torkelo commented Dec 14, 2016

think I found a simple way to refactor encrytedFields and TLSAuth into a secureJsonFields map[string]bool
330c1b9

:)

@daniellee daniellee self-assigned this Aug 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment