New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Alerting: email alert does not identify or link to the organization #6948

Closed
alexzorin opened this Issue Dec 13, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@alexzorin

alexzorin commented Dec 13, 2016

  • What did you do?

Received an Grafana alert email

  • What was the expected result?

I should be able to identify what organization and dashboard the alert has come from.

Clicking on the "View your alert rule" and "Go to alerts page" links should take me to the correct organization and dashboard.

  • What happened instead?

Email does not specify what organization the dashboard is on.

Clicking the links takes me to whatever organization I am currently logged into, which is most likely the wrong one, as we lean on the multi-organization capability of Grafana quite heavily.

So, clicking on the links just leads to "dashboard not found" and the only other way to find what alerted is to go through each organization by hand.

Alternatively I'd have to annotate each alert with the organization name but this is not a realfix.

@bergquist

This comment has been minimized.

Show comment
Hide comment
@bergquist

bergquist Dec 14, 2016

Contributor

ref #1613

Contributor

bergquist commented Dec 14, 2016

ref #1613

@alexzorin

This comment has been minimized.

Show comment
Hide comment
@alexzorin

alexzorin Dec 15, 2016

I see. Quite a messy discussion.

I think, for now, I will patch my Grafana deployment with something like https://github.com/alexzorin/grafana/commit/6f837ad2f2243776a7d81e36c3ba333d20c89871.

Maybe it is not suitable for mainline Grafana, but it's killing our usage of it today, so I'd prefer to just merge it myself.

Would you somebody familiar with Grafana codebase be able to review it (it is very short) and LMK if it is doing anything particularly egregious or dangerous?

TIA

alexzorin commented Dec 15, 2016

I see. Quite a messy discussion.

I think, for now, I will patch my Grafana deployment with something like https://github.com/alexzorin/grafana/commit/6f837ad2f2243776a7d81e36c3ba333d20c89871.

Maybe it is not suitable for mainline Grafana, but it's killing our usage of it today, so I'd prefer to just merge it myself.

Would you somebody familiar with Grafana codebase be able to review it (it is very short) and LMK if it is doing anything particularly egregious or dangerous?

TIA

@bergquist

This comment has been minimized.

Show comment
Hide comment
@bergquist

bergquist Dec 15, 2016

Contributor

@alexzorin That looks good.

But I think it would make more sense to name the querystring just orgid and not delete it from the url. Then people could share the dashboard they are looking at.

Contributor

bergquist commented Dec 15, 2016

@alexzorin That looks good.

But I think it would make more sense to name the querystring just orgid and not delete it from the url. Then people could share the dashboard they are looking at.

@bergquist bergquist self-assigned this Dec 19, 2016

@bergquist bergquist added this to the 4.2.0 milestone Dec 20, 2016

@bergquist bergquist removed their assignment Dec 20, 2016

@bergquist bergquist modified the milestones: 4.2.0-beta1, 4.2.0 Feb 14, 2017

@bergquist bergquist self-assigned this Feb 17, 2017

bergquist added a commit that referenced this issue Feb 17, 2017

@bergquist bergquist closed this in #7601 Feb 17, 2017

bergquist added a commit that referenced this issue Feb 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment