SMTP helo domain name #7223

Closed
Boolman opened this Issue Jan 11, 2017 · 1 comment

Projects

None yet

3 participants

@Boolman
Boolman commented Jan 11, 2017

I cant send smtp notifications due to grafana is using 'localhost' to identify itself with the HELO command,

Jan 11 16:11:22 mailgw02 postfix/smtpd[30833]: NOQUEUE: reject: RCPT from grafana01[10.0.0.96]: 504 5.5.2 : Helo command rejected: need fully-qualified hostname; from=grafana@foobar.com to=alerts@foobar.com proto=ESMTP helo=
Jan 11 16:11:22 mailgw02 postfix/smtpd[30833]: disconnect from grafana01[10.0.0.96]

I found in the source code it uses 'localhost', https://github.com/grafana/grafana/blob/5bf5ed68e17dabb8c3aa957c6a0b6a9e3e117817/vendor/gopkg.in/gomail.v2/smtp.go#L33-L35

I would like this to be a config option under [smtp] and maybe use the hostname by default.

@torkelo torkelo added this to the 4.2.0 milestone Jan 11, 2017
@bergquist bergquist self-assigned this Jan 12, 2017
@bergquist
Contributor

Would be great if we could avoid adding an extra setting for this.

Using instance_name would be a preferred solution.

@bergquist bergquist added a commit that closed this issue Jan 17, 2017
@bergquist bergquist feat(mailer): set localname to hostname
Some email providers does not accept localhost
in the HELO message. So we set it to hostname
instead. Our hope is that should be enough for
those providers who does not accept localhost.

closes #7223
4ea4e04
@bergquist bergquist closed this in 4ea4e04 Jan 17, 2017
@danny-allen danny-allen pushed a commit to danny-allen/grafana that referenced this issue Jan 17, 2017
@bergquist bergquist + dallen feat(mailer): set localname to hostname
Some email providers does not accept localhost
in the HELO message. So we set it to hostname
instead. Our hope is that should be enough for
those providers who does not accept localhost.

closes #7223
2b8817f
@danny-allen danny-allen pushed a commit to danny-allen/grafana that referenced this issue Jan 17, 2017
@bergquist bergquist + dallen docs(changelog): adds note about closing #7223 27eab3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment