New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Configurable csv export datetime format #8058

Closed
cederigo opened this Issue Apr 6, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@cederigo
Contributor

cederigo commented Apr 6, 2017

It would be nice if the format of the time column in the csv export was configurable.
The current format (ISO86001, ex: “2017-04-06T14:13:19.683Z”) can’t be parsed by Excel. Importing csv data is a frequent use case of mine.

I’m willing to make a pull request. Here is my implementation idea:

  • Add config section “export” (Or “csv-export”?)
  • Add config key “date_format”. Default value: “YYYY-MM-DDTHH:mm:ssZ” (ISO86001)
  • Use config value in “file_export.ts” with moment().format(..)

Any chance you accept such a pull request?

Cheers, Cédric

@cederigo

This comment has been minimized.

Show comment
Hide comment
@cederigo

cederigo Apr 25, 2017

Contributor

Any chance you accept a PR as described above?

Contributor

cederigo commented Apr 25, 2017

Any chance you accept a PR as described above?

@daniellee

This comment has been minimized.

Show comment
Hide comment
@daniellee

daniellee Apr 26, 2017

Member

Yes, we would accept a PR for this.

After some discussion with Torkel, we think the design should be like this:

  1. Combine the two CSV options in the context menu to one Export CSVoption:
    image

  2. When the user clicks on the new Export CSV option, show a modal with the following:

    • Radio button with the following options: Export Series as Rows or Export Series as Columns
    • Field for Date Format where the default value is YYYY-MM-DDTHH:mm:ssZ

Look at the Share options or Save as option to see an example of how to make a modal.

There are several issues connected to this:

Looking forward to the PR. Thanks for taking this on!

Member

daniellee commented Apr 26, 2017

Yes, we would accept a PR for this.

After some discussion with Torkel, we think the design should be like this:

  1. Combine the two CSV options in the context menu to one Export CSVoption:
    image

  2. When the user clicks on the new Export CSV option, show a modal with the following:

    • Radio button with the following options: Export Series as Rows or Export Series as Columns
    • Field for Date Format where the default value is YYYY-MM-DDTHH:mm:ssZ

Look at the Share options or Save as option to see an example of how to make a modal.

There are several issues connected to this:

Looking forward to the PR. Thanks for taking this on!

@Flyweightt

This comment has been minimized.

Show comment
Hide comment
@Flyweightt

Flyweightt May 20, 2017

Unix epoch timestamps would be great.

Flyweightt commented May 20, 2017

Unix epoch timestamps would be great.

@daniellee daniellee added this to the 4.4.0 milestone May 26, 2017

@daniellee

This comment has been minimized.

Show comment
Hide comment
@daniellee

daniellee May 26, 2017

Member

Fixed by #8282

Member

daniellee commented May 26, 2017

Fixed by #8282

@daniellee daniellee closed this May 26, 2017

daniellee added a commit that referenced this issue May 26, 2017

@daniellee

This comment has been minimized.

Show comment
Hide comment
@daniellee

daniellee May 26, 2017

Member

This could be enhanced further. The table panel does not format time columns when exported to CSV. This is a bit trickier as there might not be a time column in the table data or there might be multiple time columns.

Member

daniellee commented May 26, 2017

This could be enhanced further. The table panel does not format time columns when exported to CSV. This is a bit trickier as there might not be a time column in the table data or there might be multiple time columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment