Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Grafana doesn't send cookie for external plugin loading request #9509

Closed
mtanda opened this issue Oct 12, 2017 · 12 comments

Comments

Projects
None yet
6 participants
@mtanda
Copy link
Collaborator

commented Oct 12, 2017

  • What Grafana version are you using?
  • What datasource are you using?
    • Prometheus
  • What OS are you running grafana on?
    • Mac
  • What did you do?
    • Open dashboard which use external (not official) datasource plugin
  • What was the expected result?
    • Success to load plugin and dashboard
  • What happened instead?
    • The loading request is failed due to missing cookie.
    • We use oauth2_proxy with Grafana, it responds login page to Grafana.

Not sure, but this could be related.
systemjs/systemjs#1731

@torkelo

This comment has been minimized.

Copy link
Member

commented Oct 12, 2017

I think you need to exclude /public path from auth. This path should not require authentication.

@mtanda

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 12, 2017

Okay.
If current behavior is expected, I configure my setting to exclude /public path.

@torkelo

This comment has been minimized.

Copy link
Member

commented Oct 12, 2017

yes, grafana does not have any auth for static assets (and the standard module loaders do not send cookies for assets)

@dudusakharovich

This comment has been minimized.

Copy link

commented Oct 30, 2017

@torkelo - How do I exclude /public path from auth ?

@torkelo torkelo reopened this Nov 1, 2017

@torkelo torkelo added this to the 4.6.1 milestone Nov 1, 2017

@torkelo torkelo closed this in e19b4a9 Nov 1, 2017

torkelo added a commit that referenced this issue Nov 1, 2017

@dudusakharovich

This comment has been minimized.

Copy link

commented Nov 1, 2017

@torkelo - This fix still doesn't work for "404 unauthorized instantiation" error while trying to load dashboard which contains status panel.

@torkelo

This comment has been minimized.

Copy link
Member

commented Nov 1, 2017

@dudusakharovich what build are you using?

@dudusakharovich

This comment has been minimized.

Copy link

commented Nov 1, 2017

@torkelo - I'm using the latest one 4.6.1 which was released earlier today.

@daniellee

This comment has been minimized.

Copy link
Member

commented Nov 1, 2017

@dudusakharovich are you talking about the Vonage Status panel? It won't work until they fix it. It uses internal parts of the graph panel which is not allowed anymore.

@dudusakharovich

This comment has been minimized.

Copy link

commented Nov 1, 2017

@daniellee - I see.
So there is no point to upgrade to latest Grafana version until they will issue a fix of their own.

@stellasawicki

This comment has been minimized.

Copy link

commented Nov 2, 2017

Any workaround here? I have just upgraded to 4.6.1, but vonage-status-panel is being heavily used in my dashboards...

@aenima-x

This comment has been minimized.

Copy link

commented Nov 2, 2017

My workaround was to exclulde /public/plugins from being served by grafana a create an alias in apache to it

@daniellee

This comment has been minimized.

Copy link
Member

commented Nov 3, 2017

@stellasawicki I'm waiting for the maintainer of vonage-status-panel to merge this PR and submit a new release to be published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.